You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org> on 2008/02/18 14:52:34 UTC
[jira] Created: (HARMONY-5525) [build][drlvm] vm build fails if no
.svn data present
[build][drlvm] vm build fails if no .svn data present
-----------------------------------------------------
Key: HARMONY-5525
URL: https://issues.apache.org/jira/browse/HARMONY-5525
Project: Harmony
Issue Type: Bug
Components: build - test - ci
Reporter: Eugene S. Ostrovsky
Priority: Minor
VM fails to build if there's no .svn/entries file in working_vm source directory.
In working_vm/make/vm/vmcore.xml:
<target name="-check-version" if="svn.revision">
<uptodate property="skip.svn.stamp"
srcfile="${vm.home}/.svn/entries"
targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
</target>
This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
Thus this check have no sense.
I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5525) [build][drlvm] vm build fails if no
.svn data present
Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene S. Ostrovsky updated HARMONY-5525:
-----------------------------------------
Attachment: H5525.patch
Proposet patch.
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5525) [build][drlvm] vm build fails if no
.svn data present
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-5525:
----------------------------------------
Assignee: Alexey Varlamov
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5525) [build][drlvm] vm build fails if no
.svn data present
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-5525.
--------------------------------------
Resolution: Fixed
Eugene, thanks for reporting this.
Should be fixed at revision: 650044, please verify.
BTW, "is.svn" property is set by federated script only at the moment, to be fixed yet.
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5525) [build][drlvm] vm build fails if no
.svn data present
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov closed HARMONY-5525.
------------------------------------
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5525) [build][drlvm] vm build fails if
no .svn data present
Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591306#action_12591306 ]
Eugene S. Ostrovsky commented on HARMONY-5525:
----------------------------------------------
It works. Thanks.
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5525) [build][drlvm] vm build fails if
no .svn data present
Posted by "Eugene S. Ostrovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590856#action_12590856 ]
Eugene S. Ostrovsky commented on HARMONY-5525:
----------------------------------------------
I'm afraid the patch is already outdated.
However the issue is still relevant.
AFAIU since we have source distributions for harmony one should be able to build it without .svn data.
> [build][drlvm] vm build fails if no .svn data present
> -----------------------------------------------------
>
> Key: HARMONY-5525
> URL: https://issues.apache.org/jira/browse/HARMONY-5525
> Project: Harmony
> Issue Type: Bug
> Components: build - test - ci
> Reporter: Eugene S. Ostrovsky
> Assignee: Alexey Varlamov
> Priority: Minor
> Attachments: H5525.patch
>
>
> VM fails to build if there's no .svn/entries file in working_vm source directory.
> In working_vm/make/vm/vmcore.xml:
> <target name="-check-version" if="svn.revision">
> <uptodate property="skip.svn.stamp"
> srcfile="${vm.home}/.svn/entries"
> targetfile="${vm.home}/vmcore/include/version_svn_tag.h"/>
> </target>
> This target checks svn.revision property as precondition. AFAIK this check is always true because svn.revision is set to "unknown" string if svn doesn't present.
> Thus this check have no sense.
> I think it's better to use "is.svn" property instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.