[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #29: Optimize the bash script

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #29:
URL: https://github.com/apache/incubator-uniffle/pull/29#discussion_r913621470


##########
conf/log4j.shuffle_server.properties:
##########
@@ -0,0 +1,29 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+log4j.rootCategory=INFO, RollingAppender
+log4j.appender.console=org.apache.log4j.ConsoleAppender
+log4j.appender.console.Threshold=INFO
+log4j.appender.console.target=System.err
+log4j.appender.console.layout=org.apache.log4j.PatternLayout
+log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss} %p %c{1}: %m%n
+log4j.appender.RollingAppender=org.apache.log4j.RollingFileAppender
+log4j.appender.RollingAppender.File=./logs/shuffle_server.log

Review Comment:
   Could we introduce a environment variable like `LOG_PATH` in start script? 
   In log4j.properties, we use the environment variable to help coordinator and server to write log in different paths.



##########
bin/start-shuffle-server.sh:
##########
@@ -46,11 +51,6 @@ for file in $(ls ${JAR_DIR}/server/*.jar 2>/dev/null); do
   CLASSPATH=$CLASSPATH:$file
 done
 
-if [ -z "$HADOOP_HOME" ]; then

Review Comment:
   Why do we remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org