[GitHub] [cassandra-accord] bdeggleston commented on pull request #2: Initial Cassandra integration

[GitBox <gi...@apache.org>]

bdeggleston commented on pull request #2:
URL: https://github.com/apache/cassandra-accord/pull/2#issuecomment-1083622913


   I reworked this a bit to prevent assigning ranges to nodes that were previously replicas of said ranges. Supporting that opens a can of worms where you have to purge stale data which other nodes might still need. It's probably tractable today, but it will be much easier once repair is merged and we can require purgeable ranges are fully replicated. I also added a throttle on topology changes since the topology randomizer was keeping some burn tests busy indefinitely all by itself.
   Regarding depending on cassandra-all, In principle I don't have a strong preference... both seem kind of janky. In practice, I'd prefer sticking with the copy paste until it becomes a problem, just because it's done. I spent about 20 minutes trying to get the cassandra-all approach to work locally and the compiler couldn't find any of the classes we're using. I fiddled around with it a bit, but didn't want to spend too much time on it.
   Finally, about suggestions regarding command stores. Let's revisit this when the metadata persistence patch is ready for review. A lot of what you're suggesting is already done in that patch in one form or another.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org