You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2025/08/08 12:39:20 UTC
[I] [Testing] Verify deletion of single measure/stream [skywalking]
hanahmily opened a new issue, #13408:
URL: https://github.com/apache/skywalking/issues/13408
### Search before asking
- [x] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
- **Objective**: Verify deletion of a single measure or stream where metadata is removed immediately while underlying data is reclaimed later by merge/TTL.
- **Test Scope**
- API/CLI: `DELETE /groups/{group}/{type:stream|measure}/{name}`.
- Immediate effects: remove metadata; block new writes and routing.
- Data lifecycle: existing files remain; background merge/compaction/TTL removes them over time.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream/trace [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3863796285
Hi @hanahmily,
I've completed the implementation following your architectural guidance.
**Implementation:**
- Shared test cases in [test/cases/schema/deletion.go](cci:7://file:///d:/Coding%20Files/Open%20Source/skywalking/skywalking-banyandb/test/cases/schema/deletion.go:0:0-0:0)
- Standalone integration tests in [test/integration/standalone/schema/deletion.go](cci:7://file:///d:/Coding%20Files/Open%20Source/skywalking/skywalking-banyandb/test/integration/standalone/schema/deletion.go:0:0-0:0)
- All 3 subjects covered (measure/stream/trace)
- Full 5-step validation process implemented
I've submitted PR https://github.com/apache/skywalking-banyandb/pull/968 for your review.
Note: This PR includes standalone mode tests. I plan to add distributed mode tests in a follow-up PR to keep changes focused and reviewable.
Thanks for your guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3852768387
@hanahmily
Before I start, could you please clarify the implementation approach?
**1: Directory Structure**
should I create seperate directory like this - `test\integration\standalone\deletion` where I will write the integration tests code ? (e.g. deletion\deletion_measure_test.go, deletion\deletion_stream_test.go, deletion\deletion_suite_test.go)
I noticed this pattern is used for other integration tests (e.g., `query/`, `backup/`, `inspect/`), so I'm assuming this is the right approach?
**2. What to Test**
validate immediate metadata removal, write blocking after deletion, and schema visibility changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3852167902
hi @hanahmily I am actively working on it. I will update the progress here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3852679384
@hanahmily
Before I start, could you please clarify the implementation approach?
**Question 1: Directory Structure**
should I create seperate directory like this - `test\integration\standalone\deletion` where I will write the integration tests code ? (e.g. deletion\deletion_measure_test.go, deletion\deletion_stream_test.go, deletion\deletion_suite_test.go)
I noticed this pattern is used for other integration tests (e.g., `query/`, `backup/`, `inspect/`), so I'm assuming this is the right approach?
**Question 2: Scope of Work**
- Are the deletion APIs/methods already implemented, and I just need to write integration tests to verify them?
- Or do I need to implement both the deletion functionality and the tests?
**Question 3: Test Scenarios**
What specific scenarios should the tests cover? For example:
- Delete a single measure/stream and verify it's removed
- Verify other measures/streams are unaffected
- Error handling (e.g., deleting non-existent items)
- Any edge cases you'd like tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream [skywalking]
Posted by "OmCheeLin (via GitHub)" <gi...@apache.org>.
OmCheeLin commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3174778181
I will solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Testing] Verify deletion of single measure/stream/trace [skywalking]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on issue #13408:
URL: https://github.com/apache/skywalking/issues/13408#issuecomment-3853239936
1. Directory Structure
Create test cases under `test/cases/schema/deletion.go`. Set up the standalone test environment under `test/integration/standalone/schema/deletion.go` and the cluster test environment under `test/integration/distributed/schema/deletion.go`. The test environments should reference the shared test cases.
2. Test Process
2.1 Write several records to the target subject (measure/stream/trace).
2.2 Delete the target subject.
2.3 Verify that new data to the deleted subject is rejected and that the subject is no longer visible.
2.4 Write 20 batches of data to another subject (not the deleted one) in the same group as the deleted subject.
2.5 Verify that all written data can be retrieved successfully. This confirms that data without an associated subject does not affect merge and query operations, since subjects in the same group share the same physical files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org