You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/10 00:20:18 UTC
Review Request: FLAGS (9): Removed Configuration from
master::internal::webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5862/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/master/main.cpp bcbe35a
src/master/webui.hpp 660d5e1
src/master/webui.cpp 56134b7
Diff: https://reviews.apache.org/r/5862/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: FLAGS (9): Removed Configuration from
master::internal::webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 11, 2012, 5:22 p.m., John Sirois wrote:
> > src/master/webui.hpp, line 49
> > <https://reviews.apache.org/r/5862/diff/1/?file=120832#file120832line49>
> >
> > kill trailing ws
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5862/#review9072
-----------------------------------------------------------
On July 9, 2012, 10:20 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5862/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:20 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp bcbe35a
> src/master/webui.hpp 660d5e1
> src/master/webui.cpp 56134b7
>
> Diff: https://reviews.apache.org/r/5862/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: FLAGS (9): Removed Configuration from
master::internal::webui.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5862/#review9072
-----------------------------------------------------------
Ship it!
src/master/webui.hpp
<https://reviews.apache.org/r/5862/#comment19210>
kill trailing ws
- John Sirois
On July 9, 2012, 10:20 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5862/
> -----------------------------------------------------------
>
> (Updated July 9, 2012, 10:20 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp bcbe35a
> src/master/webui.hpp 660d5e1
> src/master/webui.cpp 56134b7
>
> Diff: https://reviews.apache.org/r/5862/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>