You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/04 11:41:34 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
ztzg opened a new pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592
`WatcherCleanerTest` performs latency checks which fail when outside of a 20+Xms window. Before this patch, X was 5ms—whereas 30+ms is frequently seen on an i5 Mac Mini running macOS Catalina.
This "dumb" patch just widens the window to 20ms, which makes it "work on my machine," but could obviously still fail in a loaded environment or VM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-773568997
> although I really don't like these type of tests, operating with real timing... a better solution would be to use some logical / mocked time.
Definitely. This is a minimal workaround to give the test a chance to succeed as I am still trying to release 3.7—but we do indeed have a steep slope to climb before we are back to test/CI stability…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-780789528
doing it now, thanks @ztzg
should I cherry pick to branch-3.7 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-780793570
Yes. Perfect—thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-780788803
@eolivelli, @symat: I have rebased this on `master`, and CI went through! Would one of you mind merging it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-773568997
> although I really don't like these type of tests, operating with real timing... a better solution would be to use some logical / mocked time.
Definitely. This is a minimal workaround to give the test a chance to succeed as I am still trying to release 3.7—but we do indeed have a steep slope to climb before we are back to test/CI stability…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-780790772
Picked to 3.7.0 branch
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592#issuecomment-792043827
Now also in `branch-3.7`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1592: ZOOKEEPER-4200: Widen latency window in WatcherCleanerTest
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1592:
URL: https://github.com/apache/zookeeper/pull/1592
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org