[GitHub] [arrow-rs] alamb commented on pull request #4038: feat: Support Timestamp +/- Interval types

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #4038:
URL: https://github.com/apache/arrow-rs/pull/4038#issuecomment-1509186806

   Also, when testing locally I got this error I think because this PR uses APIs that were introduced in chrono `0.4.24`
   
   ```
      Compiling arrow-array v37.0.0 (/Users/alamb/Software/arrow-rs2/arrow-array)
   error[E0599]: no function or associated item named `from_timestamp_micros` found for struct `NaiveDateTime` in the current scope
      --> arrow-array/src/types.rs:520:36
       |
   520 |         let prior = NaiveDateTime::from_timestamp_micros(timestamp).ok_or_else(|| {
       |                                    ^^^^^^^^^^^^^^^^^^^^^
       |                                    |
       |                                    function or associated item not found in `NaiveDateTime`
       |                                    help: there is an associated function with a similar name: `from_timestamp`
   
   
   ```
   
   I needed to make this change (which I think we should do in the PR):
   
   
   ```diff
   diff --git a/arrow-array/Cargo.toml b/arrow-array/Cargo.toml
   index 1b417bb0e..634a0aa64 100644
   --- a/arrow-array/Cargo.toml
   +++ b/arrow-array/Cargo.toml
   @@ -44,7 +44,7 @@ ahash = { version = "0.8", default-features = false, features = ["runtime-rng"]
    arrow-buffer = { workspace = true }
    arrow-schema = { workspace = true }
    arrow-data = { workspace = true }
   -chrono = { version = "0.4.23", default-features = false, features = ["clock"] }
   +chrono = { version = "0.4.24", default-features = false, features = ["clock"] }
    chrono-tz = { version = "0.8", optional = true }
    num = { version = "0.4", default-features = false, features = ["std"] }
    half = { version = "2.1", default-features = false, features = ["num-traits"] }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org