You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Freeman Fang (JIRA)" <ji...@apache.org> on 2011/06/24 07:14:47 UTC
[jira] [Created] (KARAF-686) ship jetty.xml in kit etc folder and
refer it for the http feature
ship jetty.xml in kit etc folder and refer it for the http feature
------------------------------------------------------------------
Key: KARAF-686
URL: https://issues.apache.org/jira/browse/KARAF-686
Project: Karaf
Issue Type: Bug
Affects Versions: 2.2.1
Reporter: Freeman Fang
Assignee: Freeman Fang
currently http feature has configuration like
<feature name="http" version="2.2.1" resolver="(obr)">
<configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
<config name="org.ops4j.pax.web">
org.osgi.service.http.port=8181
javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
</config>
This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054312#comment-13054312 ]
Freeman Fang commented on KARAF-686:
------------------------------------
I'd like to introduce an override flag to configfile element, the default value is true which means we keep same with current behavior.
However if we specify override="false", then if finalname already exist, then don't override it.
For example
<feature name="http" version="2.2.1" resolver="(obr)">
<configfile finalname="/etc/jetty.xml" override="false">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
<config name="org.ops4j.pax.web">
org.osgi.service.http.port=8181
javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
</config>
If etc/jetty.xml already there, don't download a new one and override it, so that customer specified jetty.xml could be used.
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved KARAF-686.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.2.2
commit fix
http://svn.apache.org/viewvc?rev=1140016&view=rev for trunk
http://svn.apache.org/viewvc?rev=1140007&view=rev for 2.2.x branch
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.2.2, 3.0.0
>
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-686) ship jetty.xml in kit etc folder and
refer it for the http feature
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054269#comment-13054269 ]
Freeman Fang commented on KARAF-686:
------------------------------------
as discussed from mailling list, http feature isn't default installed feature so we need change configfile logic so that if etc/jetty.xml exist, don't override it
> ship jetty.xml in kit etc folder and refer it for the http feature
> ------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated KARAF-686:
-------------------------------
Summary: introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist (was: ship jetty.xml in kit etc folder and refer it for the http feature)
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-686.
--------------------------------
Fixed in Apache Karaf 2.2.2.
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.2.2, 3.0.0
>
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-686) ship jetty.xml in kit etc folder and
refer it for the http feature
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054266#comment-13054266 ]
Jean-Baptiste Onofré commented on KARAF-686:
--------------------------------------------
AFAIR, Achim added a jetty.xml in a contrib folder shipped in the Karaf distribution.
I don't think it's a good idea to embed jetty.xml by default in the Karaf distribution and http feature is an optional one.
It's clear that we really need to think about a profile mechanism supporting this kind of situation :)
> ship jetty.xml in kit etc folder and refer it for the http feature
> ------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054319#comment-13054319 ]
Freeman Fang commented on KARAF-686:
------------------------------------
I actually prefer to use override="false" as default behavior as well, then let's go this way
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-686) introduce an override flag to
configfile element so that we get chance to not override the finalname if
it already exist
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054313#comment-13054313 ]
Andreas Pieber commented on KARAF-686:
--------------------------------------
IMHO overwriting an existing (possible changed file) is a bug. I can not imagine why someone would really want this behavior. So, from my point of view, using "do-not-overwrite" as default behavior is the better idea.
just my 2 cents
> introduce an override flag to configfile element so that we get chance to not override the finalname if it already exist
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-686) ship jetty.xml in kit etc folder
and refer it for the http feature
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-686 started by Freeman Fang.
> ship jetty.xml in kit etc folder and refer it for the http feature
> ------------------------------------------------------------------
>
> Key: KARAF-686
> URL: https://issues.apache.org/jira/browse/KARAF-686
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 2.2.1
> Reporter: Freeman Fang
> Assignee: Freeman Fang
>
> currently http feature has configuration like
> <feature name="http" version="2.2.1" resolver="(obr)">
> <configfile finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/2.2.2-SNAPSHOT/xml/jettyconfig</configfile>
> <config name="org.ops4j.pax.web">
> org.osgi.service.http.port=8181
> javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
> org.ops4j.pax.web.config.file=${karaf.base}/etc/jetty.xml
> </config>
> This means each time we install http feature it will download jettyconfig.xml remotely and override the local etc/jetty.xml, so any configuration we saved in local etc/jetty.xml will lose.
> We should ship jetty.xml in kit etc folder and always refer it for the http feature, which is easier for customer to configure the jetty.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira