You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/03/10 09:03:31 UTC
[PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
zclllyybb opened a new pull request, #61181:
URL: https://github.com/apache/doris/pull/61181
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Replace LOG_INFO with VLOG_CRITICAL for profile send and registration success messages to reduce log noise in production environments. Profile is not a critical part of SQL execution, so it can be adjusted like this. It's not too late to open the verbose log if any issues are found.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4035924960
skip check_coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4030007078
<details>
<summary>TPC-DS: <b>Total hot run time: 153236 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 937611b859a64b6862b25784ba4c8936b3bd3894, data reload: false
query5 4332 650 523 523
query6 328 230 207 207
query7 4212 486 274 274
query8 335 246 233 233
query9 8733 2701 2777 2701
query10 539 400 353 353
query11 7273 5862 5578 5578
query12 192 127 125 125
query13 1277 480 359 359
query14 5630 3884 3686 3686
query14_1 2772 2801 2802 2801
query15 201 192 173 173
query16 1034 515 483 483
query17 1086 709 607 607
query18 2434 440 338 338
query19 211 207 184 184
query20 132 129 126 126
query21 222 136 119 119
query22 4737 4926 4886 4886
query23 16560 16310 15644 15644
query23_1 15723 15687 15655 15655
query24 7698 1711 1327 1327
query24_1 1368 1312 1350 1312
query25 608 527 463 463
query26 1258 276 156 156
query27 2765 493 295 295
query28 4516 1881 1893 1881
query29 868 596 537 537
query30 311 246 224 224
query31 1371 1314 1250 1250
query32 84 80 86 80
query33 536 350 313 313
query34 929 912 571 571
query35 658 679 602 602
query36 1058 1090 1029 1029
query37 140 102 84 84
query38 2916 2964 2921 2921
query39 893 861 888 861
query39_1 887 829 821 821
query40 239 162 144 144
query41 68 66 65 65
query42 304 301 304 301
query43 266 254 231 231
query44
query45 201 189 186 186
query46 879 1001 607 607
query47 2090 2114 2037 2037
query48 335 335 257 257
query49 667 477 404 404
query50 703 288 236 236
query51 4102 4160 4152 4152
query52 297 299 285 285
query53 295 349 292 292
query54 330 339 268 268
query55 91 88 85 85
query56 330 323 317 317
query57 1370 1299 1268 1268
query58 288 281 281 281
query59 1327 1462 1334 1334
query60 331 333 324 324
query61 153 150 154 150
query62 624 586 554 554
query63 321 271 271 271
query64 5085 1282 995 995
query65
query66 1463 463 365 365
query67 16502 16603 16246 16246
query68
query69 387 318 293 293
query70 1001 977 906 906
query71 345 307 309 307
query72 2881 2664 2028 2028
query73 554 578 333 333
query74 10014 9941 9754 9754
query75 2856 2815 2465 2465
query76 2279 1048 677 677
query77 368 410 315 315
query78 11149 11341 10614 10614
query79 2718 817 611 611
query80 1757 635 543 543
query81 567 290 251 251
query82 982 153 118 118
query83 332 273 252 252
query84 251 117 98 98
query85 913 508 455 455
query86 409 311 304 304
query87 3185 3109 3027 3027
query88 3624 2670 2664 2664
query89 419 372 350 350
query90 2023 194 183 183
query91 165 161 137 137
query92 83 70 70 70
query93 1176 857 506 506
query94 642 324 298 298
query95 591 336 319 319
query96 637 547 230 230
query97 2474 2535 2453 2453
query98 243 222 226 222
query99 998 1005 901 901
Total cold run time: 236055 ms
Total hot run time: 153236 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4029761308
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4029761298
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #61181:
URL: https://github.com/apache/doris/pull/61181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4029924321
<details>
<summary>TPC-H: <b>Total hot run time: 27715 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 937611b859a64b6862b25784ba4c8936b3bd3894, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17658 4571 4319 4319
q2 q3 10643 805 519 519
q4 4702 372 268 268
q5 7726 1207 1020 1020
q6 183 174 149 149
q7 799 844 671 671
q8 10280 1494 1326 1326
q9 5263 4793 4676 4676
q10 6337 1924 1650 1650
q11 469 274 248 248
q12 746 575 477 477
q13 18054 2929 2221 2221
q14 226 222 212 212
q15 938 805 816 805
q16 746 776 682 682
q17 737 884 411 411
q18 5912 5404 5251 5251
q19 1444 1017 595 595
q20 500 488 396 396
q21 5300 1989 1490 1490
q22 381 329 334 329
Total cold run time: 99044 ms
Total hot run time: 27715 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4659 4619 4570 4570
q2 q3 3916 4339 3825 3825
q4 865 1193 799 799
q5 4057 4487 4371 4371
q6 186 176 155 155
q7 1797 1685 1517 1517
q8 2502 2719 2619 2619
q9 7455 7560 7359 7359
q10 3726 4048 3554 3554
q11 511 451 414 414
q12 494 607 436 436
q13 2703 3352 2317 2317
q14 296 294 275 275
q15 873 805 801 801
q16 729 766 726 726
q17 1354 1478 1307 1307
q18 7273 6878 6623 6623
q19 1072 919 898 898
q20 2148 2161 2079 2079
q21 4078 3476 3359 3359
q22 454 441 379 379
Total cold run time: 51148 ms
Total hot run time: 48383 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4035852283
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) reduce log verbosity by changing LOG_INFO to VLOG_CRITICAL for profile operations [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61181:
URL: https://github.com/apache/doris/pull/61181#issuecomment-4035852407
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org