[GitHub] [incubator-pinot] npawar commented on a change in pull request #5347: Remove some unused TimeFieldSpec related methods from Schema

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #5347:
URL: https://github.com/apache/incubator-pinot/pull/5347#discussion_r421692374



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/columnminmaxvalue/ColumnMinMaxValueGenerator.java
##########
@@ -56,32 +58,16 @@ public void addColumnMinMaxValue()
     Preconditions.checkState(_columnMinMaxValueGeneratorMode != ColumnMinMaxValueGeneratorMode.NONE);
 
     Schema schema = _segmentMetadata.getSchema();
+    Set<String> columnsToAddMinMaxValue = new HashSet<>(schema.getPhysicalColumnNames());
 
-    // Process time column
-    String timeColumnName = schema.getTimeColumnName();
-    if (timeColumnName != null) {
-      addColumnMinMaxValueForColumn(timeColumnName);
+    switch (_columnMinMaxValueGeneratorMode) {
+      case TIME:
+        columnsToAddMinMaxValue.removeAll(schema.getDimensionNames());

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org