You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/01/09 15:18:23 UTC
[GitHub] flink pull request #3083: [FLINK-2662] [optimizer] Fix translation of broadc...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/3083
[FLINK-2662] [optimizer] Fix translation of broadcasted unions.
Fix optimizer to support union with > 2 broadcasted inputs.
1. `BinaryUnionDescriptor` is changed to compute fully replicated global property if both inputs are fully replicated.
2. Enumeration of plans for binary union is changed to enforce local forward connection if input is fully replicated.
3. Add a test to check that union with three inputs can be on broadcasted side of join (fully replicated property is requested and pushed to all inputs of the union).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink unionBug3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3083
----
commit a0019d386e09f727874e54b7c8ce2ca94b26f2e5
Author: Fabian Hueske <fh...@apache.org>
Date: 2017-01-05T23:00:30Z
[FLINK-2662] [optimizer] Fix translation of broadcasted unions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3083: [FLINK-2662] [optimizer] Fix translation of broadcasted u...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3083
Seems there is a long story under this issue. I will try to catch up all the histories and have a look at this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3083: [FLINK-2662] [optimizer] Fix translation of broadc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3083
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3083: [FLINK-2662] [optimizer] Fix translation of broadcasted u...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3083
Thanks @StephanEwen. Will merge the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3083: [FLINK-2662] [optimizer] Fix translation of broadcasted u...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3083
Had a quick look as well. Seems to fix the bug correctly, test is included.
+1 from my side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---