You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/04/22 01:58:13 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/18
CB-6483 Use splash screen image from manifest on Windows8
https://issues.apache.org/jira/browse/CB-6483
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/cordova-plugin-splashscreen master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit bcbb574d05904837631c9d7c28f226091463d920
Author: Sergey Grebnov <v-...@microsoft.com>
Date: 2014-04-21T23:57:49Z
CB-6483 Use splash screen image from manifest on Windows8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use
splash scree...
Posted by Axel Nennker <ig...@gmail.com>.
- The splash screen icons should not be included into the app if the app
does not use them.
Please either don't copy them into the project or delete them if they are
not needed.
- The screen.png s are crunched on Android with significant space savings
90%. The should be crunched in the template project.
2014-05-01 1:14 GMT+02:00 asfgit <gi...@git.apache.org>:
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/cordova-plugin-splashscreen/pull/18
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/18#issuecomment-41862976
Merged, this should auto-close soon ....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/18#issuecomment-40992761
Thanks Sergey,
Your pull req will not apply cleanly to dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---