You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Udi Meiri <eh...@google.com> on 2018/10/11 21:43:18 UTC
post-commit failure emails
Hi,
https://github.com/apache/beam/pull/6635 is an attempt to notify commit
authors if their commit is suspected to have broken post-commit test.
I'd would like to get some feedback about this feature.
Is it accurate?
Is it spammy?
Thanks!
Re: post-commit failure emails
Posted by Kenneth Knowles <kl...@google.com>.
The important thing is sending just one email. And it is quite important to
get a build green before turning it on. Otherwise the suspects are, indeed,
every email address in the history of the project. We've experienced this.
On Fri, Oct 12, 2018 at 1:58 AM Robert Bradshaw <ro...@google.com> wrote:
> I agree the jenkins emails are spammy (to the point that I honestly
> can't follow all of them). +1 to emailing "suspects" as defined by
> those that impacted the build in the time it turned green to red.
> On Fri, Oct 12, 2018 at 12:55 AM Udi Meiri <eh...@google.com> wrote:
> >
> > The email trigger is setup to trigger on the 1st failure (after last
> green I presume), and to send an email to "suspects" of the first failing
> build (authors and build triggerers).
> > If a new job's first build is failing it should send an email, but only
> to suspects.
> >
> >
> https://github.com/jenkinsci/email-ext-plugin/blob/master/src/main/java/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger.java
> >
> https://github.com/jenkinsci/email-ext-plugin/blob/9012fcd1b9b2040f2d34c2723198a751eb81cce5/src/main/java/hudson/plugins/emailext/plugins/recipients/FirstFailingBuildSuspectsRecipientProvider.java#L100
> >
> > On Thu, Oct 11, 2018 at 2:48 PM Andrew Pilloud <ap...@google.com>
> wrote:
> >>
> >> There are numerous reports on this list of Jenkins emails being spammy
> on new jobs. The list of emails generated on the first run is everyone who
> has ever had a commit merged to Beam. I don't suppose that would be a
> problem if this doesn't get turned on until at least one run has passed on
> each job.
> >>
> >> Andrew
> >>
> >> On Thu, Oct 11, 2018 at 2:44 PM Udi Meiri <eh...@google.com> wrote:
> >>>
> >>> Hi,
> >>> https://github.com/apache/beam/pull/6635 is an attempt to notify
> commit authors if their commit is suspected to have broken post-commit test.
> >>>
> >>> I'd would like to get some feedback about this feature.
> >>> Is it accurate?
> >>> Is it spammy?
> >>>
> >>> Thanks!
>
Re: post-commit failure emails
Posted by Robert Bradshaw <ro...@google.com>.
I agree the jenkins emails are spammy (to the point that I honestly
can't follow all of them). +1 to emailing "suspects" as defined by
those that impacted the build in the time it turned green to red.
On Fri, Oct 12, 2018 at 12:55 AM Udi Meiri <eh...@google.com> wrote:
>
> The email trigger is setup to trigger on the 1st failure (after last green I presume), and to send an email to "suspects" of the first failing build (authors and build triggerers).
> If a new job's first build is failing it should send an email, but only to suspects.
>
> https://github.com/jenkinsci/email-ext-plugin/blob/master/src/main/java/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger.java
> https://github.com/jenkinsci/email-ext-plugin/blob/9012fcd1b9b2040f2d34c2723198a751eb81cce5/src/main/java/hudson/plugins/emailext/plugins/recipients/FirstFailingBuildSuspectsRecipientProvider.java#L100
>
> On Thu, Oct 11, 2018 at 2:48 PM Andrew Pilloud <ap...@google.com> wrote:
>>
>> There are numerous reports on this list of Jenkins emails being spammy on new jobs. The list of emails generated on the first run is everyone who has ever had a commit merged to Beam. I don't suppose that would be a problem if this doesn't get turned on until at least one run has passed on each job.
>>
>> Andrew
>>
>> On Thu, Oct 11, 2018 at 2:44 PM Udi Meiri <eh...@google.com> wrote:
>>>
>>> Hi,
>>> https://github.com/apache/beam/pull/6635 is an attempt to notify commit authors if their commit is suspected to have broken post-commit test.
>>>
>>> I'd would like to get some feedback about this feature.
>>> Is it accurate?
>>> Is it spammy?
>>>
>>> Thanks!
Re: post-commit failure emails
Posted by Udi Meiri <eh...@google.com>.
The email trigger is setup to trigger on the 1st failure (after last green
I presume), and to send an email to "suspects" of the first failing build
(authors and build triggerers).
If a new job's first build is failing it should send an email, but only to
suspects.
https://github.com/jenkinsci/email-ext-plugin/blob/master/src/main/java/hudson/plugins/emailext/plugins/trigger/FirstFailureTrigger.java
https://github.com/jenkinsci/email-ext-plugin/blob/9012fcd1b9b2040f2d34c2723198a751eb81cce5/src/main/java/hudson/plugins/emailext/plugins/recipients/FirstFailingBuildSuspectsRecipientProvider.java#L100
On Thu, Oct 11, 2018 at 2:48 PM Andrew Pilloud <ap...@google.com> wrote:
> There are numerous reports on this list of Jenkins emails being spammy on
> new jobs. The list of emails generated on the first run is everyone who has
> ever had a commit merged to Beam. I don't suppose that would be a problem
> if this doesn't get turned on until at least one run has passed on each job.
>
> Andrew
>
> On Thu, Oct 11, 2018 at 2:44 PM Udi Meiri <eh...@google.com> wrote:
>
>> Hi,
>> https://github.com/apache/beam/pull/6635 is an attempt to notify commit
>> authors if their commit is suspected to have broken post-commit test.
>>
>> I'd would like to get some feedback about this feature.
>> Is it accurate?
>> Is it spammy?
>>
>> Thanks!
>>
>
Re: post-commit failure emails
Posted by Andrew Pilloud <ap...@google.com>.
There are numerous reports on this list of Jenkins emails being spammy on
new jobs. The list of emails generated on the first run is everyone who has
ever had a commit merged to Beam. I don't suppose that would be a problem
if this doesn't get turned on until at least one run has passed on each job.
Andrew
On Thu, Oct 11, 2018 at 2:44 PM Udi Meiri <eh...@google.com> wrote:
> Hi,
> https://github.com/apache/beam/pull/6635 is an attempt to notify commit
> authors if their commit is suspected to have broken post-commit test.
>
> I'd would like to get some feedback about this feature.
> Is it accurate?
> Is it spammy?
>
> Thanks!
>