You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/08/07 15:09:55 UTC
[PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
adutra opened a new pull request, #2296:
URL: https://github.com/apache/polaris/pull/2296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3181215616
Adding if/else on the paginated call paths looks a bit of an overkill to me. As currently implemented, IIRC, pagination is controlled by the client. If the client does not request a call to be paginated, the server will work as before #1938.
IMHO, the risk of breaking clients with current pagination code is low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3165590779
> I think that this should have been used in #1938; does pagination now ignore this flag?
@snazy do you know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3164885745
Why is this unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3200391539
Moving this to draft while @dimas-b looks into this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3202360647
Following up in #2401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3185631692
Fair point. I'll look into that presently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3206366245
Closing then, thanks @dimas-b !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3165012762
> Why is this unused?
I have no idea. It was introduced in #1528, that's all I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3165532099
I think that this should have been used in #1938; does pagination now ignore this flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra closed pull request #2296: Remove unused LIST_PAGINATION_ENABLED feature configuration
URL: https://github.com/apache/polaris/pull/2296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused LIST_PAGINATION_ENABLED feature configuration [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3185064370
We have feature flags for tons of things controlled by the client -- like table location overlap, generic tables, drop-with-purge, policies, etc. This flag was put in place specifically to guard against regressions caused by the new code path introduced by pagination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org