You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/15 00:18:49 UTC

[GitHub] [incubator-superset] willbarrett opened a new pull request #9147: Move non-Superset-class views out of views/core.py

willbarrett opened a new pull request #9147: Move non-Superset-class views out of views/core.py
URL: https://github.com/apache/incubator-superset/pull/9147
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [X] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   `superset/views/core.py` is unnecessarily large. This PR removes classes from that file that are 1) not of the `Superset` class and 2) not actively being altered by another PR and puts them in locations consistent with the recommendation of SIP-35.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #9147: Move non-Superset-class views out of views/core.py

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9147: Move non-Superset-class views out of views/core.py
URL: https://github.com/apache/incubator-superset/pull/9147#issuecomment-590477733
 
 
   The pattern for model views so far has been to put it under `superset/views/{model}/` as in `superset/views/database/views.py`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on issue #9147: Move non-Superset-class views out of views/core.py

Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9147: Move non-Superset-class views out of views/core.py
URL: https://github.com/apache/incubator-superset/pull/9147#issuecomment-590498124
 
 
   Thanks @mistercrunch - this PR follows the SIP-35 package format. I opened the PR in order to get a CI run in, I'd wait until the SIP-35 vote resolves before we do a full review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #9147: Move non-Superset-class views out of views/core.py

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9147:
URL: https://github.com/apache/incubator-superset/pull/9147#issuecomment-619322800


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org