You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/08/04 16:38:45 UTC
[GitHub] flink pull request #2334: [FLINK-4310] [build] Selectively run API compatibi...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/2334
[FLINK-4310] [build] Selectively run API compatibility checks in API projects.
This moves the API compatibility checks into the API projects that use stability annotations.
Previously, every project ran the tests, regardless of whether it contained public API classes or not.
API compatibility checks are done in
- `flink-metrics-core`
- `flink-core`
- `flink-java`
- `flink-scala`
- `flink-streaming-scala`
- `flink-streaming-java`
Those were the projects where I found the `@Public` annotation being used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink selective_checks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2334
----
commit 5b77139c911cd50b5cce31fd2f9fe9ab9be520cf
Author: Stephan Ewen <se...@apache.org>
Date: 2016-08-04T16:08:14Z
[FLINK-4310] [build] Selectively run API compatibility checks in API projects.
This moves the API compatibility checks into the API projects that use stability annotations.
Previously, every project ran the tests, regardless of whether it contained public API classes or not.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2334: [FLINK-4310] [build] Selectively run API compatibility ch...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2334
True, the `flink-metrics-core` would not need it right now. I added it because it is somehow part of the public API.
We would need to re-add the annotations dependency - for that, let's check with the users that requested the "project independence" if they see any problem with that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2334: [FLINK-4310] [build] Selectively run API compatibi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2334: [FLINK-4310] [build] Selectively run API compatibility ch...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2334
`flink-metrics-core` does not contain any annotations, so the plugin will never fail here, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2334: [FLINK-4310] [build] Selectively run API compatibility ch...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2334
The added benefit is that this increases build stability on Travis, because it relies on fewer flink-specific JARs to be downloaded and cached.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2334: [FLINK-4310] [build] Selectively run API compatibility ch...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2334
Changes look good and make sense. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---