You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stefan Seifert (Jira)" <ji...@apache.org> on 2024/04/26 07:03:00 UTC

[jira] [Comment Edited] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder

    [ https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841068#comment-17841068 ] 

Stefan Seifert edited comment on SLING-12197 at 4/26/24 7:02 AM:
-----------------------------------------------------------------

bq. At least for mutable content, if i'm not wrong we use the order of the generated packages.csv from the cpconverter to deploy later.

yes, but in this case its about the ordering of (sticking to the unit test example):
# repoinit statements generated from {{io.wcm.handler.media-1.11.6.jar}}
# content package {{io.wcm.handler.media-apps-1.11.6-cp2fm-converted.zip}} with *immutable* content generated from {{io.wcm.handler.media-1.11.6.jar}}, containing nodes and scripts below {{/apps}}

they have to be executed in exactly this order - if the folders already exists after installing the package the repoinit statements have no effect.


was (Author: sseifert@pro-vision.de):
bq. At least for mutable content, if i'm not wrong we use the order of the generated packages.csv from the cpconverter to deploy later.

yes, but in this case its about the ordering of (sticking to the unit test example):
1. repoinit statements generated from {{io.wcm.handler.media-1.11.6.jar}}
2. content package {{io.wcm.handler.media-apps-1.11.6-cp2fm-converted.zip}} with *immutable* content generated from {{io.wcm.handler.media-1.11.6.jar}}, containing nodes and scripts below {{/apps}}

they have to be executed in exactly this order - if the folders already exists after installing the package the repoinit statements have no effect.

> cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-12197
>                 URL: https://issues.apache.org/jira/browse/SLING-12197
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.3.4
>            Reporter: Stefan Seifert
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.3.8
>
>         Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content package is installed compared when uploading the OSGi bundle with the Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for each directory found in the Sling-Initial-Content (see also [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders, but only for the actual JSON files found in the process. as a result, the folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content defines a primary type of {{nt:unstructured}} - it is not allowed to created such a node directly below a {{nt:folder}} node - but it is allowed to do so below a {{sling:Folder}} node



--
This message was sent by Atlassian Jira
(v8.20.10#820010)