You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 01:51:32 UTC
[GitHub] [apisix] spacewander opened a new pull request #3637: fix: we should ensure one upstream only have one determinable scheme
spacewander opened a new pull request #3637:
URL: https://github.com/apache/apisix/pull/3637
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3637: fix: we should ensure one upstream only have one determinable scheme
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3637:
URL: https://github.com/apache/apisix/pull/3637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3637: fix: we should ensure one upstream only have one determinable scheme
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3637:
URL: https://github.com/apache/apisix/pull/3637#discussion_r581593554
##########
File path: doc/plugins/proxy-rewrite.md
##########
@@ -35,7 +35,7 @@ The `proxy-rewrite` is an upstream proxy information rewriting plugin, which sup
| Name | Type | Requirement | Default | Valid | Description |
| --------- | ------------- | ----------- | ------- | ----------------- | ------------------------------------------------------------ |
-| scheme | string | optional | "http" | ["http", "https"] | Upstream new `schema` forwarding protocol. |
+| scheme | string | optional | "http" | ["http", "https"] | Deprecated. It's recommended to set the proxy `scheme` in the Upstream object's `scheme` field instead.|
Review comment:
@Firstsawyou
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3637: fix: we should ensure one upstream only have one determinable scheme
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #3637:
URL: https://github.com/apache/apisix/pull/3637#discussion_r580807083
##########
File path: doc/plugins/proxy-rewrite.md
##########
@@ -35,7 +35,7 @@ The `proxy-rewrite` is an upstream proxy information rewriting plugin, which sup
| Name | Type | Requirement | Default | Valid | Description |
| --------- | ------------- | ----------- | ------- | ----------------- | ------------------------------------------------------------ |
-| scheme | string | optional | "http" | ["http", "https"] | Upstream new `schema` forwarding protocol. |
+| scheme | string | optional | "http" | ["http", "https"] | Deprecated. It's recommended to set the proxy `scheme` in the Upstream object's `scheme` field instead.|
Review comment:
I think in the `Description` part, a description should be added or the original description should be retained.
such as:
Upstream new `schema` forwarding protocol (Deprecated. It's recommended to set the proxy `scheme` in the Upstream object's `scheme` field instead).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org