You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Harbs <ha...@gmail.com> on 2020/01/20 17:31:22 UTC
Re: [royale-asjs] branch develop updated: UIComponent.enable needs to
be bindable. Should fix #675
A little OT, but this commit jogged my memory…
What can we do about getting [Inspectable] tags working for tooling in MXML?
IIRC, last time I asked Josh, he told me there was something missing from the compiler to enable code intelligence from these tags. I don’t remember the details.
Harbs
> On Jan 20, 2020, at 7:25 PM, aharui@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 3ef5abc UIComponent.enable needs to be bindable. Should fix #675
> 3ef5abc is described below
>
> commit 3ef5abc7ede3c036ee10e3baf2710a4d8683eba9
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Mon Jan 20 09:24:48 2020 -0800
>
> UIComponent.enable needs to be bindable. Should fix #675
> ---
> frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> index 57a6ea6..ecdd879 100644
> --- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> @@ -1302,6 +1302,7 @@ public class UIComponent extends UIBase
> private var _enabled:Boolean = true;
>
> [Inspectable(category="General", enumeration="true,false", defaultValue="true")]
> + [Bindable("disabledChange")]
>
> /**
> * @copy mx.core.IUIComponent#enabled
>
Re: [royale-asjs] branch develop updated: UIComponent.enable needs to
be bindable. Should fix #675
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Um, wow, that is OT ;-0. Have you checked if Inspectable is in the list of keep-as3-metadata in the SWC compile-xx-config.xml files?
On 1/20/20, 9:31 AM, "Harbs" <ha...@gmail.com> wrote:
A little OT, but this commit jogged my memory…
What can we do about getting [Inspectable] tags working for tooling in MXML?
IIRC, last time I asked Josh, he told me there was something missing from the compiler to enable code intelligence from these tags. I don’t remember the details.
Harbs
> On Jan 20, 2020, at 7:25 PM, aharui@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C6b143e2845a6489d295508d79dce98ec%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637151382965493551&sdata=BfsLHWOFG10%2B%2B499VWpjGqCPtFrCrmgfnX1UqGFuVYo%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 3ef5abc UIComponent.enable needs to be bindable. Should fix #675
> 3ef5abc is described below
>
> commit 3ef5abc7ede3c036ee10e3baf2710a4d8683eba9
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Mon Jan 20 09:24:48 2020 -0800
>
> UIComponent.enable needs to be bindable. Should fix #675
> ---
> frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> index 57a6ea6..ecdd879 100644
> --- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> @@ -1302,6 +1302,7 @@ public class UIComponent extends UIBase
> private var _enabled:Boolean = true;
>
> [Inspectable(category="General", enumeration="true,false", defaultValue="true")]
> + [Bindable("disabledChange")]
>
> /**
> * @copy mx.core.IUIComponent#enabled
>
Re: [royale-asjs] branch develop updated: UIComponent.enable needs to
be bindable. Should fix #675
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
Enum values in [Inspectable] and [Style] metadata are definitely handled by
VSCode's MXML completion when they're available. I can see it working for
both Flex and Feathers projects.
Like Alex suggested, the -keep-as3-metadata+=Inspectable compiler option
may help.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Mon, Jan 20, 2020 at 9:31 AM Harbs <ha...@gmail.com> wrote:
> A little OT, but this commit jogged my memory…
>
> What can we do about getting [Inspectable] tags working for tooling in
> MXML?
>
> IIRC, last time I asked Josh, he told me there was something missing from
> the compiler to enable code intelligence from these tags. I don’t remember
> the details.
>
> Harbs
>
> > On Jan 20, 2020, at 7:25 PM, aharui@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > aharui pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> > new 3ef5abc UIComponent.enable needs to be bindable. Should fix
> #675
> > 3ef5abc is described below
> >
> > commit 3ef5abc7ede3c036ee10e3baf2710a4d8683eba9
> > Author: Alex Harui <ah...@apache.org>
> > AuthorDate: Mon Jan 20 09:24:48 2020 -0800
> >
> > UIComponent.enable needs to be bindable. Should fix #675
> > ---
> > frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> > index 57a6ea6..ecdd879 100644
> > --- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> > +++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
> > @@ -1302,6 +1302,7 @@ public class UIComponent extends UIBase
> > private var _enabled:Boolean = true;
> >
> > [Inspectable(category="General", enumeration="true,false",
> defaultValue="true")]
> > + [Bindable("disabledChange")]
> >
> > /**
> > * @copy mx.core.IUIComponent#enabled
> >
>
>