[jira] [Commented] (MSHARED-1017) null passed to DependencyFilter in EclipseAetherFilterTransformerTest

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469923#comment-17469923 ] 

Michael Osipov commented on MSHARED-1017:
-----------------------------------------

Nice catch, we added null checks on purpose. For obvious reasons...

> null passed to DependencyFilter in EclipseAetherFilterTransformerTest
> ---------------------------------------------------------------------
>
>                 Key: MSHARED-1017
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1017
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-common-artifact-filters
>    Affects Versions: maven-common-artifact-filters-3.2.0
>            Reporter: Marián Konček
>            Priority: Major
>         Attachments: 0001-Pass-empty-list-instead-of-null-to-DependencyFilter..patch
>
>
> The tests in EclipseAetherFilterTransformerTest.java contain calls like `assertTrue( dependencyFilter.accept( newDependencyNode( "g:a:v", "compile" ), null ) );`.
> The API of DependencyFilter states that the second parameter may not be null:
> https://maven.apache.org/resolver/maven-resolver-api/apidocs/org/eclipse/aether/graph/DependencyFilter.html
> The issue was encountered when executing the tests with maven-resolver-util version 1.7.3 and causes maven build to fail because maven-resolver added requireNonNull in some release after 1.4.2 which is the declared dependency.
> Attaching proposed patch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)