You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/30 09:00:14 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
MaxGekk opened a new pull request, #37725:
URL: https://github.com/apache/spark/pull/37725
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1338028956
All issues have been fixed. At the moment, all sql tests (in *.sql files) raise exception with error classes. I would propose to merge this change to detect exceptions that are not ported on error classes yet. @cloud-fan Are you ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1025206912
##########
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##########
@@ -5,7 +5,12 @@ select concat_ws()
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-requirement failed: concat_ws requires at least one argument.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "requirement failed: concat_ws requires at least one argument.; line 1 pos 7"
Review Comment:
SPARK-41173
##########
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##########
@@ -14,7 +19,12 @@ select format_string()
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-requirement failed: format_string() should take at least 1 argument; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "requirement failed: format_string() should take at least 1 argument; line 1 pos 7"
Review Comment:
SPARK-41173
##########
sql/core/src/test/resources/sql-tests/results/ansi/string-functions.sql.out:
##########
@@ -1579,7 +1589,12 @@ select to_binary('abc', 1)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-The 'format' parameter of function 'to_binary' needs to be a string literal.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "The 'format' parameter of function 'to_binary' needs to be a string literal.; line 1 pos 7"
Review Comment:
SPARK-41174
##########
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-join.sql.out:
##########
@@ -3263,7 +3268,12 @@ select * from
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 72
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 72"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-join.sql.out:
##########
@@ -546,7 +546,12 @@ SELECT udf('') AS `xxx`, udf(i) AS i, udf(k), udf(t) AS t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 29
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 29"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -105,7 +125,12 @@ SELECT t1.i1 FROM t1, mydb2.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -122,7 +147,12 @@ SELECT i1 FROM t1, mydb1.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -21,7 +21,12 @@ select from_csv('1', 1)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-The expression '1' is not a valid schema string.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "The expression '1' is not a valid schema string.; line 1 pos 7"
Review Comment:
SPARK-41179
##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/join.sql.out:
##########
@@ -546,7 +546,12 @@ SELECT '' AS `xxx`, i, k, t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 20
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i' is ambiguous, could be: spark_catalog.default.j1_tbl.i, spark_catalog.default.j2_tbl.i.; line 1 pos 20"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/select_implicit.sql.out:
##########
@@ -453,7 +463,12 @@ SELECT count(b) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 1 pos 13
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 1 pos 13"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/select_implicit.sql.out:
##########
@@ -429,7 +434,12 @@ SELECT count(x.a) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 10
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 10"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_implicit.sql.out:
##########
@@ -242,7 +242,12 @@ SELECT udf(count(*)) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 14
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 14"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##########
@@ -31,7 +31,12 @@ SELECT default.myDoubleAvg(int_col1, 3) as my_avg from t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Invalid number of arguments for function spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Invalid number of arguments for function spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7"
Review Comment:
SPARK-41176
##########
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_implicit.sql.out:
##########
@@ -432,7 +437,12 @@ SELECT udf(count(udf(x.a))) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 14
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 14"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -78,7 +83,12 @@ SELECT t1.i1 FROM t1, mydb1.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -69,7 +69,12 @@ select to_json(named_struct('a', 1, 'b', 2), named_struct('mode', 'PERMISSIVE'))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Must use a map() function for options.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Must use a map() function for options.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##########
@@ -48,7 +53,12 @@ SELECT default.udaf1(int_col1) as udaf1 from t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Can not load class 'test.non.existent.udaf' when registering the function 'spark_catalog.default.udaf1', please make sure it is on the classpath; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Can not load class 'test.non.existent.udaf' when registering the function 'spark_catalog.default.udaf1', please make sure it is on the classpath; line 1 pos 7"
Review Comment:
SPARK-41175
##########
sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-select_implicit.sql.out:
##########
@@ -457,7 +467,12 @@ SELECT udf(count(udf(b))) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 1 pos 21
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 1 pos 21"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -187,7 +194,12 @@ select to_csv(named_struct('a', 1, 'b', 2), named_struct('mode', 'PERMISSIVE'))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Must use a map() function for options.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Must use a map() function for options.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -69,7 +69,12 @@ SELECT i1 FROM t1, mydb1.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/extract.sql.out:
##########
@@ -317,7 +317,12 @@ select extract(not_supported from c) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Literals of type 'not_supported' are currently not supported for the string type.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
Review Comment:
SPARK-41182
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -131,7 +161,12 @@ SELECT t1.i1 FROM t1, mydb1.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -140,7 +175,12 @@ SELECT i1 FROM t1, mydb2.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -96,7 +111,12 @@ SELECT i1 FROM t1, mydb2.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -78,7 +83,12 @@ select to_json(named_struct('a', 1, 'b', 2), map('mode', 1))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -157,7 +164,12 @@ select from_json('{"a":1}', 'a INT', named_struct('mode', 'PERMISSIVE'))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Must use a map() function for options.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Must use a map() function for options.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -87,7 +97,12 @@ SELECT mydb1.t1.i1 FROM t1, mydb1.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'mydb1.t1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'mydb1.t1.i1' is ambiguous, could be: spark_catalog.mydb1.t1.i1, spark_catalog.mydb1.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/extract.sql.out:
##########
@@ -335,7 +345,12 @@ select extract(not_supported from j) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Literals of type 'not_supported' are currently not supported for the interval day to second type.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
Review Comment:
SPARK-41182
##########
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out:
##########
@@ -149,7 +189,12 @@ SELECT t1.i1 FROM t1, mydb2.t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 't1.i1' is ambiguous, could be: spark_catalog.mydb2.t1.i1, spark_catalog.mydb2.t1.i1.; line 1 pos 7"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -30,20 +35,12 @@ select from_csv('1', 'a InvalidType')
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Cannot parse the data type:
-[PARSE_SYNTAX_ERROR] Syntax error at or near 'InvalidType': extra input 'InvalidType'(line 1, pos 2)
-
-== SQL ==
-a InvalidType
---^^^
-
-Failed fallback parsing:
-DataType invalidtype is not supported.(line 1, pos 2)
-
-== SQL ==
-a InvalidType
---^^^
-; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Cannot parse the data type: \n[PARSE_SYNTAX_ERROR] Syntax error at or near 'InvalidType': extra input 'InvalidType'(line 1, pos 2)\n\n== SQL ==\na InvalidType\n--^^^\n\nFailed fallback parsing: \nDataType invalidtype is not supported.(line 1, pos 2)\n\n== SQL ==\na InvalidType\n--^^^\n; line 1 pos 7"
Review Comment:
SPARK-41180
##########
sql/core/src/test/resources/sql-tests/results/extract.sql.out:
##########
@@ -326,7 +331,12 @@ select extract(not_supported from i) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Literals of type 'not_supported' are currently not supported for the interval year to month type.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
Review Comment:
SPARK-41182
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -126,7 +136,12 @@ select from_json('{"a":1}', 1)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-The expression '1' is not a valid schema string.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "The expression '1' is not a valid schema string.; line 1 pos 7"
Review Comment:
SPARK-41179
##########
sql/core/src/test/resources/sql-tests/results/extract.sql.out:
##########
@@ -1081,7 +1101,12 @@ select extract(MONTH from interval '123 12:34:56.789123123' DAY TO SECOND)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Literals of type 'MONTH' are currently not supported for the interval day to second type.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Literals of type 'MONTH' are currently not supported for the interval day to second type.; line 1 pos 7"
Review Comment:
SPARK-41182
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -166,7 +178,12 @@ select from_json('{"a":1}', 'a INT', map('mode', 1))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/join.sql.out:
##########
@@ -3235,7 +3240,12 @@ select * from
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 63
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'f1' is ambiguous, could be: j.f1, j.f1.; line 2 pos 63"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out:
##########
@@ -5,7 +5,12 @@ select concat_ws()
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-requirement failed: concat_ws requires at least one argument.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "requirement failed: concat_ws requires at least one argument.; line 1 pos 7"
Review Comment:
SPARK-41173
##########
sql/core/src/test/resources/sql-tests/results/json-functions.sql.out:
##########
@@ -135,20 +150,12 @@ select from_json('{"a":1}', 'a InvalidType')
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Cannot parse the data type:
-[PARSE_SYNTAX_ERROR] Syntax error at or near 'InvalidType': extra input 'InvalidType'(line 1, pos 2)
-
-== SQL ==
-a InvalidType
---^^^
-
-Failed fallback parsing:
-DataType invalidtype is not supported.(line 1, pos 2)
-
-== SQL ==
-a InvalidType
---^^^
-; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Cannot parse the data type: \n[PARSE_SYNTAX_ERROR] Syntax error at or near 'InvalidType': extra input 'InvalidType'(line 1, pos 2)\n\n== SQL ==\na InvalidType\n--^^^\n\nFailed fallback parsing: \nDataType invalidtype is not supported.(line 1, pos 2)\n\n== SQL ==\na InvalidType\n--^^^\n; line 1 pos 7"
Review Comment:
SPARK-41180
##########
sql/core/src/test/resources/sql-tests/results/postgreSQL/select_implicit.sql.out:
##########
@@ -239,7 +239,12 @@ SELECT count(*) FROM test_missing_target x, test_missing_target y
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 10
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 10"
Review Comment:
SPARK-41172
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -52,7 +49,12 @@ select from_csv('1', 'a INT', named_struct('mode', 'PERMISSIVE'))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Must use a map() function for options.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Must use a map() function for options.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out:
##########
@@ -14,7 +19,12 @@ select format_string()
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-requirement failed: format_string() should take at least 1 argument; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "requirement failed: format_string() should take at least 1 argument; line 1 pos 7"
Review Comment:
SPARK-41173
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -61,7 +63,12 @@ select from_csv('1', 'a INT', map('mode', 1))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/string-functions.sql.out:
##########
@@ -1511,7 +1521,12 @@ select to_binary('abc', 1)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-The 'format' parameter of function 'to_binary' needs to be a string literal.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "The 'format' parameter of function 'to_binary' needs to be a string literal.; line 1 pos 7"
Review Comment:
SPARK-41174
##########
sql/core/src/test/resources/sql-tests/results/csv-functions.sql.out:
##########
@@ -196,4 +208,9 @@ select to_csv(named_struct('a', 1, 'b', 2), map('mode', 1))
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "A type of keys and values in map() must be string, but got map<string,int>.; line 1 pos 7"
Review Comment:
SPARK-41181
##########
sql/core/src/test/resources/sql-tests/results/extract.sql.out:
##########
@@ -924,7 +939,12 @@ select extract(DAY from interval '2-1' YEAR TO MONTH)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Literals of type 'DAY' are currently not supported for the interval year to month type.; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Literals of type 'DAY' are currently not supported for the interval year to month type.; line 1 pos 7"
Review Comment:
SPARK-41182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1319616814
- SPARK-41173: https://github.com/apache/spark/pull/38705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1319476144
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
URL: https://github.com/apache/spark/pull/37725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1471019944
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1029406863
##########
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##########
@@ -48,7 +53,12 @@ SELECT default.udaf1(int_col1) as udaf1 from t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Can not load class 'test.non.existent.udaf' when registering the function 'spark_catalog.default.udaf1', please make sure it is on the classpath; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Can not load class 'test.non.existent.udaf' when registering the function 'spark_catalog.default.udaf1', please make sure it is on the classpath; line 1 pos 7"
Review Comment:
@panbingkun Any ideas why we still don't see the error class `CANNOT_LOAD_FUNCTION_CLASS ` introduced by your PR https://github.com/apache/spark/pull/38696?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1337540603
@MaxGekk Have all the issues mentioned in this pr been solved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1318946953
@panbingkun @LuciferYang @itholic @cloud-fan @srielau @anchovYu @entong I changed the mechanism of generating SQL golden files in this PR to detect the exceptions that haven't been ported on error classes. There are still a few exceptions for which I opened the JIRAs:
- SPARK-41172
- SPARK-41173
- SPARK-41174
- SPARK-41175
- SPARK-41176
- SPARK-41179
- SPARK-41180
- SPARK-41181
- SPARK-41182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37725:
URL: https://github.com/apache/spark/pull/37725#issuecomment-1337553614
> @MaxGekk Have all the issues mentioned in this pr been solved?
Let me rebase it on the recent master and regenerate golden files, then we will see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37725: [DO-NOT-MERGE] Exceptions without error classes in SQL golden files
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37725:
URL: https://github.com/apache/spark/pull/37725#discussion_r1039856927
##########
sql/core/src/test/resources/sql-tests/results/udaf.sql.out:
##########
@@ -31,7 +31,12 @@ SELECT default.myDoubleAvg(int_col1, 3) as my_avg from t1
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
-Invalid number of arguments for function spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7
+{
+ "errorClass" : "LEGACY",
+ "messageParameters" : {
+ "message" : "Invalid number of arguments for function spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7"
Review Comment:
This one should disappear after https://github.com/apache/spark/pull/38919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org