You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/03 12:46:35 UTC
[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1387: [Improve] [ci] Enhance license-maven-plugin
asdf2014 opened a new pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
This PR enhanced license-maven-plugin plugin by disabling sortArtifactByName option and adding timeout options.
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818644211
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
IMO, this is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818758842
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
For me, the license is very important, I can't accept such an error (even if its probability is small),@kezhenxu94 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818687542
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
You can refer to https://github.com/apache/incubator-seatunnel/pull/1372#discussion_r818375324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818769234
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
This issue is not resolved and I hope that this issue gets discussed by others so that we can reach a consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818763115
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Maybe it would better that you can merge this first and go through from the begin to understand the whole logic, and then we can discuss more effectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818719678
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
I'm sure most people don't want to heavily modify this file over and over again. License is very important, it is best to list the differences before merging with #1210.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818703646
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
FYI, https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818703096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818704682
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
@CalvinKirs here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818779659
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
hi, it's better not to mark an issue as resolved until it's clearly resolved, let's hear what others have to say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818695433
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
About two years ago, this dependence was added by https://github.com/apache/incubator-seatunnel/commit/82297e4dfc61562b8f9a7984defaeb58b72a9465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818688085
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
But it has been added, seems you don’t know it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818747761
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
If the user needs to add a new jar, does he also need to follow such a sorting rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818802620
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
It is clear enough I believe 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r819219527
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
@kezhenxu94 It is success refer to https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849 and I responded refer to https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818866682 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818728716
##########
File path: bin/license.py
##########
@@ -58,7 +58,13 @@
"javax.servlet.jsp:jsp-api:2.1": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet.jsp:jsp-api:2.1 - https://javaee.github.io/javaee-jsp-api)",
"javax.servlet:servlet-api:2.5": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet:servlet-api:2.5 - http://servlet-spec.java.net)",
"oro:oro:2.0.8": "(Apache License, Version 1.1) ORO (oro:oro:2.0.8 - https://mvnrepository.com/artifact/oro/oro)",
- "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)"
+ "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)",
+ "asm:asm:3.1": "(BSD License) ASM (asm:asm:3.1 - https://asm.ow2.io/license.html)",
+ "com.ibm.icu:icu4j:55.1": "(Unicode/ICU License) ICU4J (com.ibm.icu:icu4j:55.1 - http://icu-project.org/)",
+ "jakarta.activation:jakarta.activation-api:1.2.1": "(EDL 1.0) Jakarta Activation API (jakarta.activation:jakarta.activation-api:1.2.1 - https://github.com/eclipse-ee4j/jaf)",
+ "org.apache.zookeeper:zookeeper:3.3.1": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.3.1 - http://zookeeper.apache.org/zookeeper)",
+ "org.apache.zookeeper:zookeeper:3.4.6": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - http://zookeeper.apache.org/zookeeper)",
+ "org.codehaus.jettison:jettison:1.1": "(Apache License, Version 2.0) Jettison (org.codehaus.jettison:jettison:1.1 - https://github.com/jettison-json/jettison)"
Review comment:
> Only needed when some licenses are ambiguous and need to be determined manually
ok, got it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818737383
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
However, the license of MySQL dependence has been reported by license-maven plugin, so the script have to ignore it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818830180
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
The script can handle it, and mark the Github Action job as failed, and then we can know and avoid to use it. Really, you should read the script and understand the logic first please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818866682
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
@kezhenxu94 Cool, thanks big old 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r819220365
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
> @kezhenxu94 It was successful refer to [#1387 (comment)](https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849) and I responded refer to [#1387 (comment)](https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818866682) 😂
🤣 OK, the conversation is marked as resolved and I didn't notice this morning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818724147
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
or,https://github.com/CalvinKirs/incubator-seatunnel/blob/revert-license/seatunnel-dist/release-docs/LICENSE Here is the latest, you can copy it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818760448
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
I think we have already communicated on this issue. What we need is only to print what needs to be added in the log, rather than requiring users to learn Python-related things and then execute Python scripts. You have to know that the main developers of ST are still Java-based.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818801221
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
> It just copy-paste thing, so it is not hard like you said
Try not to let contributors add it manually, so this script is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818647980
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
yup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818646739
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
You mean this line of code, or the MySQL dependence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r819219934
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
@kezhenxu94 It was successful refer to https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849 and I responded refer to https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818866682 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818832478
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
Also because of this, I suspect there are more unnecessary dependencies are included which are provided/test scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818771988
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
I agree the license is important, but I disagree there is error.
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Maybe it would better that you can merge this first and go through from the begin to understand the whole logic, and then we can discuss more effectively.
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Maybe it would better that you can merge this first and go through from the begin to understand the whole logic, and then we can discuss more effectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818746545
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
No, this is not about code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818725887
##########
File path: bin/license.py
##########
@@ -58,7 +58,13 @@
"javax.servlet.jsp:jsp-api:2.1": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet.jsp:jsp-api:2.1 - https://javaee.github.io/javaee-jsp-api)",
"javax.servlet:servlet-api:2.5": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet:servlet-api:2.5 - http://servlet-spec.java.net)",
"oro:oro:2.0.8": "(Apache License, Version 1.1) ORO (oro:oro:2.0.8 - https://mvnrepository.com/artifact/oro/oro)",
- "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)"
+ "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)",
+ "asm:asm:3.1": "(BSD License) ASM (asm:asm:3.1 - https://asm.ow2.io/license.html)",
+ "com.ibm.icu:icu4j:55.1": "(Unicode/ICU License) ICU4J (com.ibm.icu:icu4j:55.1 - http://icu-project.org/)",
+ "jakarta.activation:jakarta.activation-api:1.2.1": "(EDL 1.0) Jakarta Activation API (jakarta.activation:jakarta.activation-api:1.2.1 - https://github.com/eclipse-ee4j/jaf)",
+ "org.apache.zookeeper:zookeeper:3.3.1": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.3.1 - http://zookeeper.apache.org/zookeeper)",
+ "org.apache.zookeeper:zookeeper:3.4.6": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - http://zookeeper.apache.org/zookeeper)",
+ "org.codehaus.jettison:jettison:1.1": "(Apache License, Version 2.0) Jettison (org.codehaus.jettison:jettison:1.1 - https://github.com/jettison-json/jettison)"
Review comment:
Only needed when some licenses are ambiguous and need to be determined manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818837529
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Then can you tell me why the problem of ignoring mysql occurs?
https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849 This is the root cause of the problem, if you can fix this then it will be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818643277
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
Can you explain why so many jars are newly introduced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818648526
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
We will not add mysql dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818771723
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
Usually adding a jar contains multiple dependencies, we are to simplify the contributor, not to increase the threshold for him. Increasing the collation is not a good idea, for me it's cumbersome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818646209
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
You mean licenses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r819206480
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Well, looks like my comment last night didn't successfully post out....
"Merge this first" is not a good practice in open source, from my experience, merged codes are rarely reviewed again and discussed, we don't have a deadline in open source so let's get things done completely (at least reach to an concensus).
The issue here to me is that the plugin includes all dependencies from all scopes, including test, provided, @asdf2014 did you try the option [`excludedScopes`](https://www.mojohaus.org/license-maven-plugin/add-third-party-mojo.html#excludedScopes) to exclude scopes `test`, `provided` dependencies?
And because of this, I suspect that there are more unnecessary dependencies (`provided` scope) license added. Please overhaul these,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818717913
##########
File path: bin/license.py
##########
@@ -58,7 +58,13 @@
"javax.servlet.jsp:jsp-api:2.1": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet.jsp:jsp-api:2.1 - https://javaee.github.io/javaee-jsp-api)",
"javax.servlet:servlet-api:2.5": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet:servlet-api:2.5 - http://servlet-spec.java.net)",
"oro:oro:2.0.8": "(Apache License, Version 1.1) ORO (oro:oro:2.0.8 - https://mvnrepository.com/artifact/oro/oro)",
- "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)"
+ "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)",
+ "asm:asm:3.1": "(BSD License) ASM (asm:asm:3.1 - https://asm.ow2.io/license.html)",
+ "com.ibm.icu:icu4j:55.1": "(Unicode/ICU License) ICU4J (com.ibm.icu:icu4j:55.1 - http://icu-project.org/)",
+ "jakarta.activation:jakarta.activation-api:1.2.1": "(EDL 1.0) Jakarta Activation API (jakarta.activation:jakarta.activation-api:1.2.1 - https://github.com/eclipse-ee4j/jaf)",
+ "org.apache.zookeeper:zookeeper:3.3.1": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.3.1 - http://zookeeper.apache.org/zookeeper)",
+ "org.apache.zookeeper:zookeeper:3.4.6": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - http://zookeeper.apache.org/zookeeper)",
+ "org.codehaus.jettison:jettison:1.1": "(Apache License, Version 2.0) Jettison (org.codehaus.jettison:jettison:1.1 - https://github.com/jettison-json/jettison)"
Review comment:
If there is a new dependency that needs to be added, do I have to modify it every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818750236
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
So does this mean that this tool is not available and that it is likely to lead us into a trap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818754749
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
The script can help to add new licenses and put them in the right position, so users wouldn’t need to do it manually, even this sort rule is by character, which is simply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818764941
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
Yes it is printing log, I mean it also can be able to add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818756228
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
No I don’t think so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
> Maybe it would better that you can merge this first and go through from the begin to understand the whole logic, and then we can discuss more effectively.
“Merge this first” is not a good practice IMO, codes get merged are rarely reviewed and re-discussed from my experience, we don’t have a deadline to deliver something in open source so let’s resolve it first before merging.
The issue here to me is that you unnecessarily deal with the unused dependencies, because the plugin analyzed them, right?
did you try the option [`<excludedScopes>`](https://www.mojohaus.org/license-maven-plugin/add-third-party-mojo.html#excludedScopes) of that plugin to exclude test/provided scope dependencies, this is an easy-found option that can avoid this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818831444
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -263,64 +276,120 @@ The text of each license is the standard Apache 2.0 license.
(Apache 2.0 License) Spark Project Streaming (org.apache.spark:spark-streaming_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) Spark Project Tags (org.apache.spark:spark-tags_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) Spark Project Unsafe (org.apache.spark:spark-unsafe_2.11:2.3.4 - http://spark.apache.org/)
+ (Apache 2.0 License) Spark Project Unsafe (org.apache.spark:spark-unsafe_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) TiSpark Project Assembly (com.pingcap.tispark:tispark-assembly:2.4.1 - http://github.copm/pingcap/tispark)
(Apache 2.0 License) TiSpark Project Core Internal (com.pingcap.tispark:tispark-core-internal:2.4.1 - http://github.copm/pingcap/tispark)
(Apache 2.0 License) TiSpark Project TiKV Java Client (com.pingcap.tikv:tikv-client:2.4.1 - http://github.copm/pingcap/tispark/tikv-client)
(Apache 2.0) Moshi (com.squareup.moshi:moshi:1.8.0 - https://github.com/square/moshi/moshi)
+ (Apache 2.0) OkHttp (com.squareup.okhttp:okhttp:1.0.2 - https://github.com/square/okhttp/okhttp)
+ (Apache 2.0) OkHttp (com.squareup.okhttp:okhttp:2.4.0 - https://github.com/square/okhttp/okhttp)
+ (Apache 2.0) Okio (com.squareup.okio:okio:1.4.0 - https://github.com/square/okio/okio)
(Apache 2.0) error-prone annotations (com.google.errorprone:error_prone_annotations:2.3.4 - http://nexus.sonatype.org/oss-repository-hosting.html/error_prone_parent/error_prone_annotations)
+ (Apache 2.0) error-prone annotations (com.google.errorprone:error_prone_annotations:2.8.0 - https://errorprone.info/error_prone_annotations)
Review comment:
Please check these duplicated dependencies with different versions, normally these should not be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818703096
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
I noticed it, that’s why I added this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818863138
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -263,64 +276,120 @@ The text of each license is the standard Apache 2.0 license.
(Apache 2.0 License) Spark Project Streaming (org.apache.spark:spark-streaming_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) Spark Project Tags (org.apache.spark:spark-tags_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) Spark Project Unsafe (org.apache.spark:spark-unsafe_2.11:2.3.4 - http://spark.apache.org/)
+ (Apache 2.0 License) Spark Project Unsafe (org.apache.spark:spark-unsafe_2.11:2.4.0 - http://spark.apache.org/)
(Apache 2.0 License) TiSpark Project Assembly (com.pingcap.tispark:tispark-assembly:2.4.1 - http://github.copm/pingcap/tispark)
(Apache 2.0 License) TiSpark Project Core Internal (com.pingcap.tispark:tispark-core-internal:2.4.1 - http://github.copm/pingcap/tispark)
(Apache 2.0 License) TiSpark Project TiKV Java Client (com.pingcap.tikv:tikv-client:2.4.1 - http://github.copm/pingcap/tispark/tikv-client)
(Apache 2.0) Moshi (com.squareup.moshi:moshi:1.8.0 - https://github.com/square/moshi/moshi)
+ (Apache 2.0) OkHttp (com.squareup.okhttp:okhttp:1.0.2 - https://github.com/square/okhttp/okhttp)
+ (Apache 2.0) OkHttp (com.squareup.okhttp:okhttp:2.4.0 - https://github.com/square/okhttp/okhttp)
+ (Apache 2.0) Okio (com.squareup.okio:okio:1.4.0 - https://github.com/square/okio/okio)
(Apache 2.0) error-prone annotations (com.google.errorprone:error_prone_annotations:2.3.4 - http://nexus.sonatype.org/oss-repository-hosting.html/error_prone_parent/error_prone_annotations)
+ (Apache 2.0) error-prone annotations (com.google.errorprone:error_prone_annotations:2.8.0 - https://errorprone.info/error_prone_annotations)
Review comment:
Okay, you mean the license-maven-plugin normally should merge them, right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818773043
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
I mean, no sort of rule is needed. that's it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818801512
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
What do you mean issues..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818717001
##########
File path: bin/license.py
##########
@@ -58,7 +58,13 @@
"javax.servlet.jsp:jsp-api:2.1": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet.jsp:jsp-api:2.1 - https://javaee.github.io/javaee-jsp-api)",
"javax.servlet:servlet-api:2.5": "(CDDL + GPLv2 with classpath exception) Java Servlet API (javax.servlet:servlet-api:2.5 - http://servlet-spec.java.net)",
"oro:oro:2.0.8": "(Apache License, Version 1.1) ORO (oro:oro:2.0.8 - https://mvnrepository.com/artifact/oro/oro)",
- "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)"
+ "org.hyperic:sigar:1.6.5.132": "(Apache License, Version 2.0) Sigar (org.hyperic:sigar:1.6.5.132 - https://github.com/hyperic/sigar)",
+ "asm:asm:3.1": "(BSD License) ASM (asm:asm:3.1 - https://asm.ow2.io/license.html)",
+ "com.ibm.icu:icu4j:55.1": "(Unicode/ICU License) ICU4J (com.ibm.icu:icu4j:55.1 - http://icu-project.org/)",
+ "jakarta.activation:jakarta.activation-api:1.2.1": "(EDL 1.0) Jakarta Activation API (jakarta.activation:jakarta.activation-api:1.2.1 - https://github.com/eclipse-ee4j/jaf)",
+ "org.apache.zookeeper:zookeeper:3.3.1": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.3.1 - http://zookeeper.apache.org/zookeeper)",
+ "org.apache.zookeeper:zookeeper:3.4.6": "(Apache License, Version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - http://zookeeper.apache.org/zookeeper)",
+ "org.codehaus.jettison:jettison:1.1": "(Apache License, Version 2.0) Jettison (org.codehaus.jettison:jettison:1.1 - https://github.com/jettison-json/jettison)"
Review comment:
@asdf2014 I would like to know, under what circumstances will these contents be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818745363
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
You should check your code, normally it shouldn't make such an error. He is not our dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818765784
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
It just copy-paste thing, so it is not hard like you said
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818775072
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
The aim of script is reduced the threshold of users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818825355
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
You just solved the current problem, when if there is a second one similar to MySQL (protocol compatible), but we don't actually use it, this situation is a potential problem for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818810076
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
> Try not to let contributors add it manually, so this script is useless
@wuchunfu Agree, this script is able to added automatically, but @CalvinKirs suggested only do checks, FYI, https://github.com/apache/incubator-seatunnel/pull/1210#issuecomment-1032511917, so I have to let this script to print log instead of adding by default. If we can get final conclusion, then only need to change the third option of script to enable this ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818840025
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
You ignore mysql because the tool detects it, but the real reason is the above. I mean, if you don't fix it, there will be more unnecessary licenses in the future. (License compatible but not actually used), but CI is still successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818701167
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
you can refer this https://github.com/apache/incubator-seatunnel/blob/dev/pom.xml#L257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818743921
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
I can agree with your idea. Because this situation is not usual, it would be few change in future like this one https://github.com/apache/incubator-seatunnel/pull/1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818803889
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
What do you mean issue…
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
It is clear enough I believe 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818744540
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0 license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver (org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver (org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server (org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 - http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 - http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 - http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 - http://www.joda.org/joda-time/)
Review comment:
I can’t agree with your idea. Because this situation is not usual, it would be few change in future like this one https://github.com/apache/incubator-seatunnel/pull/1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818747977
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
Like I said before, it caused by license-maven-plugin with sortArtifactByName option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1387: [Improve] [ci] Enhance license-maven-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818712392
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you can add it yourself
Review comment:
I mean, it's not something a license check script needs to care about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org