You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/01/16 22:46:10 UTC
Review Request 72020: RANGER-2692:RangerKafkaAuthorizer support for
ConsumerGroup resource for authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72020/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2692
https://issues.apache.org/jira/browse/RANGER-2692
Repository: ranger
Description
-------
RANGER-2692:RangerKafkaAuthorizer support for ConsumerGroup resource for authorization
Diffs
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 38bc31c
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 43dd35f
plugin-kafka/src/test/resources/kafka-policies.json e4f5db1
security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10033.java PRE-CREATION
Diff: https://reviews.apache.org/r/72020/diff/1/
Testing
-------
Tested in local VM. Unit test all passing.
Thanks,
Ramesh Mani
Re: Review Request 72020: RANGER-2692:RangerKafkaAuthorizer support
for ConsumerGroup resource for authorization
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72020/#review219312
-----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json
Line 79 (original), 95 (patched)
<https://reviews.apache.org/r/72020/#comment307464>
Please consider ordering accessTypes by the itemIds?
- Abhay Kulkarni
On Jan. 16, 2020, 10:46 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72020/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2020, 10:46 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2692
> https://issues.apache.org/jira/browse/RANGER-2692
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2692:RangerKafkaAuthorizer support for ConsumerGroup resource for authorization
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 38bc31c
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 43dd35f
> plugin-kafka/src/test/resources/kafka-policies.json e4f5db1
> security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10033.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72020/diff/1/
>
>
> Testing
> -------
>
> Tested in local VM. Unit test all passing.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72020: RANGER-2692:RangerKafkaAuthorizer support
for ConsumerGroup resource for authorization
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72020/#review219314
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 16, 2020, 11:42 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72020/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2020, 11:42 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2692
> https://issues.apache.org/jira/browse/RANGER-2692
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2692:RangerKafkaAuthorizer support for ConsumerGroup resource for authorization
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 38bc31c
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 43dd35f
> plugin-kafka/src/test/resources/kafka-policies.json e4f5db1
> security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10033.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72020/diff/2/
>
>
> Testing
> -------
>
> Tested in local VM. Unit test all passing.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72020: RANGER-2692:RangerKafkaAuthorizer support
for ConsumerGroup resource for authorization
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72020/
-----------------------------------------------------------
(Updated Jan. 16, 2020, 11:42 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Adddressed review comments
Bugs: RANGER-2692
https://issues.apache.org/jira/browse/RANGER-2692
Repository: ranger
Description
-------
RANGER-2692:RangerKafkaAuthorizer support for ConsumerGroup resource for authorization
Diffs (updated)
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 38bc31c
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 43dd35f
plugin-kafka/src/test/resources/kafka-policies.json e4f5db1
security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10033.java PRE-CREATION
Diff: https://reviews.apache.org/r/72020/diff/2/
Changes: https://reviews.apache.org/r/72020/diff/1-2/
Testing
-------
Tested in local VM. Unit test all passing.
Thanks,
Ramesh Mani