You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/07 15:07:31 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #17521: [improve] Use Text Blocks to improve JSON text
coderzc opened a new pull request, #17521:
URL: https://github.com/apache/pulsar/pull/17521
### Motivation
The JSON text has a lot of escape characters, we can use [Text Blocks](https://docs.oracle.com/en/java/javase/15/text-blocks/index.html) to improve it.
### Modifications
Use Text Blocks to improve JSON text
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17521: [improve] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1240496008
Could you use `"` instead of `'`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242585719
> Overall job is optional, so you don't need to rerun the failure job.
It seems "Pulsar CI / Pulsar CI checks completed" be dependent on other tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242599293
> @momo-jun PTAL
I just notice this is for example shown on the doc. It can be a concern that leading whitespace may cause margin error. But fortunately Java text block detect margin by the close `"""` and these changes should be fine. See also https://docs.oracle.com/en/java/javase/15/text-blocks/index.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242601037
> Cool! Glad to see we gradually use new features beyond JDK11.
>
> Out of the topic, we may be careful about using some new features like `var` - they will cause significant style inconsistency.
@tisonkun Another PR(#17296) also uses Text Blocks to improve doc annotation, please take a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1241934641
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242158613
This is a good start, but we may need to note that this change does not benefit the cherry-pick operations, the old version doesn't support this syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242597239
@momo-jun PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1241489553
@nodece PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1241575095
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1240514368
> Could you use `"` instead of `'`?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242124128
Overall job is optional, so you don't need to rerun the failure job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #17521:
URL: https://github.com/apache/pulsar/pull/17521#issuecomment-1242584456
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17521: [improve][doc] Use Text Blocks to improve JSON text
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17521:
URL: https://github.com/apache/pulsar/pull/17521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org