[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34738:
URL: https://github.com/apache/spark/pull/34738#discussion_r770002006



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -726,6 +726,21 @@ object DataSourceStrategy
     }
   }
 
+  protected[sql] def translateSortOrders(sortOrders: Seq[SortOrder]): Seq[SortOrderV2] = {
+    sortOrders.map {

Review comment:
       Hi, All. This broke Scala 2.13 compilation.
   ```
   [error] /home/runner/work/spark/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:730:20: match may not be exhaustive.
   [error] It would fail on the following input: SortOrder(_, _, _, _)
   [error]     sortOrders.map {
   [error]                    ^
   [warn] 24 warnings found
   [error] one error found
   [error] (sql / Compile / compileIncremental) Compilation failed
   [error] Total time: 267 s (04:27), completed Dec 15, 2021 5:57:25 AM
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org