You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/06 23:23:37 UTC

Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
-----------------------------------------------------------

(Updated July 6, 2018, 11:23 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Rebased.


Bugs: MESOS-8567
    https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description
-------

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test.


Diffs (updated)
-----

  src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 0484933b42d0bd66c689b06cb48f492eef7bc606 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 
  src/tests/disk_profile_adaptor_tests.cpp 4485f1635f484ce6e1c7c532eedb277f5eee118b 


Diff: https://reviews.apache.org/r/65640/diff/7/

Changes: https://reviews.apache.org/r/65640/diff/6-7/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao