[GitHub] [kafka] vvcephei commented on a change in pull request #11676: KAFKA-13605: checkpoint position in state stores

[GitBox <gi...@apache.org>]

vvcephei commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r788981897



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##########
@@ -85,8 +85,23 @@
      * @throws IllegalStateException If store gets registered after initialized is already finished
      * @throws StreamsException if the store's change log does not contain the partition
      */
+    default void register(final StateStore store,
+                  final StateRestoreCallback stateRestoreCallback) {
+        register(store, stateRestoreCallback, null);
+    }
+
+    /**
+     * Register and possibly restores the specified storage engine.
+     *
+     * @param store the storage engine
+     * @param stateRestoreCallback the restoration callback logic for log-backed state stores upon restart
+     * @param checkpointCallback called to checkpoint position metatadata of state stores
+     *
+     * @throws IllegalStateException If store gets registered after initialized is already finished
+     * @throws StreamsException if the store's change log does not contain the partition
+     */
     void register(final StateStore store,
-                  final StateRestoreCallback stateRestoreCallback);
+                  final StateRestoreCallback stateRestoreCallback, final CheckpointCallback checkpointCallback);

Review comment:
       Yep! We wanted to get this PR hashed out and then propose it. Thanks for keeping an eye out!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org