[GitHub] [helix] desaikomal commented on a diff in pull request #2381: Adding a new metric to report number of partitions with missing top state beyond threshold

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2381:
URL: https://github.com/apache/helix/pull/2381#discussion_r1116245494


##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -54,6 +54,7 @@ public enum RebalanceStatus {
 
   // Gauges
   private SimpleDynamicMetric<Long> _numOfPartitions;
+  private SimpleDynamicMetric<Long> _missingTopStatePartitionsBeyondThresholdGauge;

Review Comment:
   comment or link to PR, so that we know why we added this



##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java:
##########
@@ -70,6 +71,7 @@ public enum RebalanceStatus {
   // Counters
   private SimpleDynamicMetric<Long> _successfulTopStateHandoffDurationCounter;
   private SimpleDynamicMetric<Long> _successTopStateHandoffCounter;
+  @Deprecated

Review Comment:
   do you want to add comment as to we are deprecating this and replacing it with another one, so that others have context on why we marked them for deprecation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org