You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by da...@apache.org on 2012/10/31 23:27:15 UTC
svn commit: r1404392 - in /pig/branches/branch-0.10: CHANGES.txt
test/org/apache/pig/test/TestParamSubPreproc.java
test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
Author: daijy
Date: Wed Oct 31 22:27:15 2012
New Revision: 1404392
URL: http://svn.apache.org/viewvc?rev=1404392&view=rev
Log:
PIG-2943: DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health (jgordon via dvryaboy)
Modified:
pig/branches/branch-0.10/CHANGES.txt
pig/branches/branch-0.10/test/org/apache/pig/test/TestParamSubPreproc.java
pig/branches/branch-0.10/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
Modified: pig/branches/branch-0.10/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/branches/branch-0.10/CHANGES.txt?rev=1404392&r1=1404391&r2=1404392&view=diff
==============================================================================
--- pig/branches/branch-0.10/CHANGES.txt (original)
+++ pig/branches/branch-0.10/CHANGES.txt Wed Oct 31 22:27:15 2012
@@ -36,7 +36,9 @@ PIG-2727: PigStorage Source tagging does
BUG FIXES
-PIG-2801: grunt "sh" command should invoke the shell implicitly instead of calling exec directly with the command tokens
+PIG-2943: DevTests, Refactor Windows checks to use new Util.WINDOWS method for code health (jgordon via dvryaboy)
+
+PIG-2801: grunt "sh" command should invoke the shell implicitly instead of calling exec directly with the command tokens
(jgordon via daijy)
PIG-2800: pig.additional.jars path separator should align with File.pathSeparator instead of being hard-coded to ":"
Modified: pig/branches/branch-0.10/test/org/apache/pig/test/TestParamSubPreproc.java
URL: http://svn.apache.org/viewvc/pig/branches/branch-0.10/test/org/apache/pig/test/TestParamSubPreproc.java?rev=1404392&r1=1404391&r2=1404392&view=diff
==============================================================================
--- pig/branches/branch-0.10/test/org/apache/pig/test/TestParamSubPreproc.java (original)
+++ pig/branches/branch-0.10/test/org/apache/pig/test/TestParamSubPreproc.java Wed Oct 31 22:27:15 2012
@@ -1198,7 +1198,7 @@ public class TestParamSubPreproc extends
pigOStream = new FileWriter(basedir + "/output1.pig");
String[] arg = {"date=`perl -e 'print \"20080228\n20070101\"' | head -n 1`"};
- if (System.getProperty("os.name").toUpperCase().startsWith("WINDOWS"))
+ if (Util.WINDOWS)
arg[0] = "date=`perl -e 'print \\\"20080228\n20070101\\\"' | head -n 1`";
String[] argFiles = null;
ps.genSubstitutedFile(pigIStream , pigOStream , arg , argFiles);
Modified: pig/branches/branch-0.10/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
URL: http://svn.apache.org/viewvc/pig/branches/branch-0.10/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java?rev=1404392&r1=1404391&r2=1404392&view=diff
==============================================================================
--- pig/branches/branch-0.10/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java (original)
+++ pig/branches/branch-0.10/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java Wed Oct 31 22:27:15 2012
@@ -138,7 +138,7 @@ public class TestTypeCheckingValidatorNe
private static final String simpleEchoStreamingCommand;
static {
- if (System.getProperty("os.name").toUpperCase().startsWith("WINDOWS"))
+ if (Util.WINDOWS)
simpleEchoStreamingCommand = "perl -ne 'print \\\"$_\\\"'";
else
simpleEchoStreamingCommand = "perl -ne 'print \"$_\"'";