[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde

[GitBox <gi...@apache.org>]

andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142286548

   > @andygrove Why remove the `AsLogicalPlan` type param from the codec? In our project we use a custom logical plan representation (based on a different query AST) and it is very helpful to be able to plugin our own `LogicalPlan` type.
   
   @thinkharderdev the main goal was to delegate to `datafusion-proto` for logical plan serde so that we don't have to duplicate all of this code in Ballista. A secondary goal was to use the `datafusion-proto` API for converting plans to bytes and bytes to plans without having dependencies on internals of that crate (so that we can easily change the format in the future). If we create a trait for this API does that make it easy for you to plug in your own implementation?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org