You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/29 20:49:06 UTC
[GitHub] [trafficserver] bryancall opened a new pull request #8189: Minor updates to HTTP version validation
bryancall opened a new pull request #8189:
URL: https://github.com/apache/trafficserver/pull/8189
Renamed the functions to be more explicit about only supporting HTTP/1.x
Changed the version check to be only a logic statement
This is a update to #7875
I would like to pull #7875 into the 9.1.x branch because we right now have an autest for testing invalid versions and it is failing right now (because of #7885). However, @zwoop and I didn't like the function names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #8189: Minor updates to HTTP version validation
Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #8189:
URL: https://github.com/apache/trafficserver/pull/8189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8189: Minor updates to HTTP version validation
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8189:
URL: https://github.com/apache/trafficserver/pull/8189#issuecomment-892183310
Cherry picked to 9.1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8189: Minor updates to HTTP version validation
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8189:
URL: https://github.com/apache/trafficserver/pull/8189#issuecomment-890102816
Seems ok. Since the HttpSM currently only manipulates HTTP/1.x headers the original more generic name made some sense. Currently for HTTP/2 (and I assume HTTP/3) the headers are translated to HTTP/1.x before they are passed from the ProxyTransaction to the HttpSM. Hopefully that translation disappears at some point. Then the naming will need to be reconsidered (and the function will need to be expanded).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org