You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mkurz (via GitHub)" <gi...@apache.org> on 2024/02/25 11:18:44 UTC
[PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
mkurz opened a new pull request, #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114
Same as in
- https://github.com/apache/incubator-pekko-http/pull/486
- https://github.com/apache/incubator-pekko/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114#discussion_r1501895207
##########
build.sbt:
##########
@@ -76,7 +76,8 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
+ ("com.lightbend.paradox" % "sbt-paradox" % "0.10.3").exclude("com.typesafe.sbt", "sbt-web")),
Review Comment:
This is a mistake (it should be 0.9.2), can you fix it in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114#discussion_r1501895207
##########
build.sbt:
##########
@@ -76,7 +76,8 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
+ ("com.lightbend.paradox" % "sbt-paradox" % "0.10.3").exclude("com.typesafe.sbt", "sbt-web")),
Review Comment:
This is a mistake, can you fix it?
##########
build.sbt:
##########
@@ -76,7 +76,8 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
+ ("com.lightbend.paradox" % "sbt-paradox" % "0.10.3").exclude("com.typesafe.sbt", "sbt-web")),
Review Comment:
This is a mistake, can you fix it in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on code in PR #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114#discussion_r1501799773
##########
build.sbt:
##########
@@ -76,7 +76,8 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
+ ("com.lightbend.paradox" % "sbt-paradox" % "0.10.3").exclude("com.typesafe.sbt", "sbt-web")),
Review Comment:
Why `0.10.3` here? Shouldn't that be either downgraded to 0.9.2 or upgraded to 0.10.6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko-sbt-paradox]
Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on code in PR #114:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/114#discussion_r1501899611
##########
build.sbt:
##########
@@ -76,7 +76,8 @@ lazy val pekkoPlugin = project
addSbtPlugin(
// When updating the sbt-paradox version,
// remember to also update project/plugins.sbt
- "com.lightbend.paradox" % "sbt-paradox" % "0.10.3"),
+ ("com.lightbend.paradox" % "sbt-paradox" % "0.10.3").exclude("com.typesafe.sbt", "sbt-web")),
Review Comment:
Pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org