svn commit: r899830 - /felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java

[pd...@apache.org]

Author: pderop
Date: Fri Jan 15 22:10:29 2010
New Revision: 899830

URL: http://svn.apache.org/viewvc?rev=899830&view=rev
Log:
fixed bug when creating a ConfigurationDependency (the pid was not set)

Modified:
    felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java

Modified: felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java
URL: http://svn.apache.org/viewvc/felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java?rev=899830&r1=899829&r2=899830&view=diff
==============================================================================
--- felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java (original)
+++ felix/trunk/dependencymanager/runtime/src/main/java/org/apache/felix/dm/runtime/ComponentManager.java Fri Jan 15 22:10:29 2010
@@ -336,8 +336,14 @@
     {
         ConfigurationDependency cd = dm.createConfigurationDependency();
         String pid = parser.getString(DescriptorParam.pid);
+        if (pid == null) {
+            throw new IllegalArgumentException("pid attribute not provided in ConfigurationDependency declaration");
+        }
+        cd.setPid(pid);
+        
         String propagate = parser.getString(DescriptorParam.propagate, "false");
         cd.setPropagate("true".equals(propagate));
+        
         String callback = parser.getString(DescriptorParam.updated, "updated");
         cd.setCallback(callback);
         return cd;