You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/23 21:22:33 UTC
[GitHub] [airflow] s-mcqueen opened a new pull request #7247: [AIRFLOW-6625]
Explicitly log using utf-8 encoding
s-mcqueen opened a new pull request #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247
This is the standard encoding supported by Airflow. We should be explicit about logging using
this encoding.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #7247: [AIRFLOW-6625]
Explicitly log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247#issuecomment-578047119
Can you please amend the commit message to follow
> Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
You can use `git commit --amend` :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7247:
[AIRFLOW-6625] Explicitly log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247#issuecomment-578254368
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7247:
[AIRFLOW-6625] Explicitly log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247#issuecomment-577901642
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=h1) Report
> Merging [#7247](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/61201a5e5cf2ece1253fccdde0dd5833267d9ee2?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7247 +/- ##
=========================================
- Coverage 85.34% 85.05% -0.3%
=========================================
Files 791 791
Lines 40135 40137 +2
=========================================
- Hits 34255 34140 -115
- Misses 5880 5997 +117
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `88.76% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `87.57% <0%> (-3.11%)` | :arrow_down: |
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=footer). Last update [61201a5...6df28cb](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7247:
[AIRFLOW-6625] Explicitly log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247#issuecomment-577883090
Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
Adding a new operator? Check this short [guide](https://github
.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows
how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7247: [AIRFLOW-6625]
Explicitly log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247#issuecomment-577901642
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=h1) Report
> Merging [#7247](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/61201a5e5cf2ece1253fccdde0dd5833267d9ee2?src=pr&el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7247 +/- ##
==========================================
- Coverage 85.34% 84.91% -0.44%
==========================================
Files 791 791
Lines 40135 40135
==========================================
- Hits 34255 34079 -176
- Misses 5880 6056 +176
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `88.76% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-44%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `80.95% <0%> (-7.24%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `75.62% <0%> (-6.88%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7247/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `88.75% <0%> (-0.59%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=footer). Last update [61201a5...730a13b](https://codecov.io/gh/apache/airflow/pull/7247?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] aoen merged pull request #7247: [AIRFLOW-6625] Explicitly
log using utf-8 encoding
Posted by GitBox <gi...@apache.org>.
aoen merged pull request #7247: [AIRFLOW-6625] Explicitly log using utf-8 encoding
URL: https://github.com/apache/airflow/pull/7247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services