You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Gary Gregory <ga...@gmail.com> on 2020/11/26 14:21:38 UTC
Re: [commons-codec] branch master updated: Track changes
May you please show the PR number in the description? See the first action
in the list. This will give us better provenance for changes.
TY!
Gary
On Thu, Nov 26, 2020 at 9:13 AM <ah...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> aherbert pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-codec.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 4369d10 Track changes
> 4369d10 is described below
>
> commit 4369d10a6019c5ec9515242ae61b4a8b8ad178f2
> Author: Alex Herbert <ah...@apache.org>
> AuthorDate: Thu Nov 26 14:12:02 2020 +0000
>
> Track changes
> ---
> src/changes/changes.xml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index e71cb70..774f0c4 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -45,6 +45,7 @@ The <action> type attribute can be add,update,fix,remove.
> <release version="1.16" date="TBD" description="Feature and fix
> release.">
> <action dev="ggregory" type="update"
> due-to="Dependabot">Update build actions/setup-java from v1.4.1 to v1.4.2
> #60.</action>
> <action dev="ggregory" type="update" due-to="Gary
> Gregory">Update commons.jacoco.version 0.8.5 to 0.8.6 (Fixes Java 15
> builds).</action>
> + <action dev="aherbert" type="fix" due-to="James
> Gan">Remove duplicated words from javadocs.</action>
> </release>
>
> <release version="1.15" date="2020-09-01" description="Feature and
> fix release.">
>
>
Re: [commons-codec] branch master updated: Track changes
Posted by Gary Gregory <ga...@gmail.com>.
Then do it because that's the "style" we've been using, just like we use
the changes.xml "issue" attribute to refer to the associated Jira issue,
but in this case it's not a Jira #, it's a PR#.
Note that the Maven changes plugin does not know about PRs in that field,
so we use the PR# in the description. Maybe that plugin can be configured
to work with both Jira and GitHub links but that's a different topic.
Gary
Re: [commons-codec] branch master updated: Track changes
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le jeu. 26 nov. 2020 à 15:22, Gary Gregory <ga...@gmail.com> a écrit :
>
> May you please show the PR number in the description? See the first action
> in the list. This will give us better provenance for changes.
At first thought, I don't see that this info belongs in the "changes" file.
[Rationale: Display *what* has changed (and *why* if there is an associated
report). *How* (provenance) is provided by the commit.]
Regards,
Gilles
> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org