You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ntrp <gi...@git.apache.org> on 2017/11/29 19:33:23 UTC

[GitHub] kafka pull request #4277: STRUCT schema equality check failing for complex o...

GitHub user ntrp opened a pull request:

    https://github.com/apache/kafka/pull/4277

    STRUCT schema equality check failing for complex objects

    *The schema equality need to be done with the equals method to avoid unwanted side effects. When applied to complex objects with the same schema it was failing.*
    
    *To test the faulty behaviour try calling the method on a complex object (at least 3 levels of nesting and array fields with a lot of objects).*
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ntrp/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4277
    
----
commit 950f0e426d1927c000f99d0c1c8d40e6b10cabc1
Author: Ivan Greguric Ortolan <iv...@gmail.com>
Date:   2017-11-29T19:23:44Z

    fixed the convertToJson method, struct equality check failing for complex JSON

----


---