You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tenfef <gi...@git.apache.org> on 2015/07/17 02:35:42 UTC
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
GitHub user tenfef opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/36
Change UUID to use [UIDevice identifierForVendor]
instead of generating a UUID, just use the unique identifierForVendor for device which is valid since iOS 6.0
Since Cordova dropped support for iOS 5, I think this is a safe change and the UUID will be persistent across installs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tenfef/cordova-plugin-device master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit f28cb50cdc7d65a8f0c9cb74e4fdc53ac4516a37
Author: Jordan <jo...@gmail.com>
Date: 2015-07-17T00:33:41Z
Changed UUID to use [UIDevice identifierForVendor]
instead of generating a UUID, just use the unique identifierForVendor for device which is valid since iOS 6.0
Since Cordova dropped support for iOS 5, I think this is a safe change and the UUID will be persistent across installs.
commit 810c3c9fe06003cd916ffe5b668cd9286c506f31
Author: Jordan <jo...@gmail.com>
Date: 2015-07-17T00:34:42Z
Remove line incorrectly committed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122255716
I think you might still want to check in user defaults first, so the uuid value doesn't change for users who already had the app installed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by tenfef <gi...@git.apache.org>.
Github user tenfef commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122514250
Have made said changes to documentation. https://github.com/apache/cordova-plugin-device/pull/36/files#diff-04c6e90faac2675aa89e2176d2eec7d8R173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by tenfef <gi...@git.apache.org>.
Github user tenfef commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122511314
I have made the adjustments above to the documentation and also restored the use of NSUserDefaults to maintain backwards compatibility.
Jira issue is here: https://issues.apache.org/jira/browse/CB-9386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122194054
First of all, an issue is needed before merging this, create a new one here http://issues.cordova.io/ and use the identifier you get on this pull request title.
Second, this change will require a change in the docs too, so people can know that the plugin uses the identifierForVendor for the UUID, what is it, and it's peculiarities. The whole iOS Quirks section should be changed to document this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122512809
I think you should add to the readme that users with the app installed will get the previous stored UUID instead of the identifierForVendor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org