You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lukas Jirkovsky <l....@gmail.com> on 2017/05/04 21:54:48 UTC
[PATCH] gpg-agent storage - add support for /run based sockets V4
Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
Now it also unescapes the path according to gpgconf man page which
says the path is percent-escaped.
I'm not sure about using svn_cstring_split on svn_stringbuf_t data
member though, but I could not find a similar functionality for string
buffer.
[[[
Find gpg-agent socket using gpgconf if possible.
This allows detection of socket with Gnupg >= 2.1.13
which changed the default socket path to /run/user/UID/gnupg
* subversion/libsvn_subr/gpg_agent.c
(find_gpgconf_agent_socket): new function to find
gpg-agent socket using gpgconf
(find_running_gpg_agent): use find_gpgconf_agent_socket
to detect socket when possible.
]]]
Re: [PATCH] gpg-agent storage - add support for /run based sockets V4
Posted by James McCoy <ja...@jamessan.com>.
On Fri, May 05, 2017 at 11:29:09PM -0400, James McCoy wrote:
> On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote:
> > On 4 May 2017 at 23:54, Lukas Jirkovsky <l....@gmail.com> wrote:
> > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
> >
> > I just noticed I accidentally generated the patch from inside the
> > "subversion" subdirectory. I hope that's not a problem.
>
> No, it's not. :) It looks good to me, other than a few typos. I'll
> test it out soon.
Thanks for the patch! Committed in r1794166.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Re: [PATCH] gpg-agent storage - add support for /run based sockets V4
Posted by James McCoy <ja...@jamessan.com>.
On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote:
> On 4 May 2017 at 23:54, Lukas Jirkovsky <l....@gmail.com> wrote:
> > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
>
> I just noticed I accidentally generated the patch from inside the
> "subversion" subdirectory. I hope that's not a problem.
No, it's not. :) It looks good to me, other than a few typos. I'll
test it out soon.
Cheers,
--
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Re: [PATCH] gpg-agent storage - add support for /run based sockets V4
Posted by Lukas Jirkovsky <l....@gmail.com>.
On 4 May 2017 at 23:54, Lukas Jirkovsky <l....@gmail.com> wrote:
> Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent socket.
I just noticed I accidentally generated the patch from inside the
"subversion" subdirectory. I hope that's not a problem.