You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2016/05/14 18:59:10 UTC

[GitHub] spark pull request: [SPARK-15328][MLLIB][ML] Word2Vec import for o...

GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/13119

    [SPARK-15328][MLLIB][ML] Word2Vec import for original binary format

    ## What changes were proposed in this pull request?
    
    Add `loadGoogleModel()` function to import original wor2vec binary format.
    
    
    ## How was this patch tested?
    
    `mllib.feature.Word2VecSuite` and `ml.feature.Word2VecSuite`
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13119
    
----
commit 17f98089b2371033c5c88933123f070c7ad4c145
Author: Yuming Wang <wa...@yhd.com>
Date:   2016-05-14T18:44:15Z

    Load Google word2vec model

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15328][MLLIB][ML] Word2Vec import for o...

Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the pull request:

    https://github.com/apache/spark/pull/13119#issuecomment-219981677
  
    I think this is a nice idea - however it will have to wait until after 2.0 release is done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #13119: [SPARK-15328][MLLIB][ML] Word2Vec import for orig...

Posted by wangyum <gi...@git.apache.org>.
Github user wangyum closed the pull request at:

    https://github.com/apache/spark/pull/13119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-15328][MLLIB][ML] Word2Vec import for o...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/13119#issuecomment-219237391
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org