You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by walterddr <gi...@git.apache.org> on 2018/05/22 13:35:21 UTC
[GitHub] flink pull request #6054: [FLINK-8986][e2e-test] Flink end to end test REST ...
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/6054
[FLINK-8986][e2e-test] Flink end to end test REST API
## What is the purpose of the change
Adding end to end test for REST APIs for FLIP-6 generated endpoints.
*This is a follow up PR based on #5849 and the changes & improvements are based on @zentol 's comment and suggestions.*
*This PR depends on one commit in #5863 (ea12737) *
## Brief change log
- Adding in `flink-rest-api-test` module and `test_rest_api.sh` for end-to-end testing
- Adding in payload YAML file for endpoints used by REST APIs if any POST/PATCH endpoint requires a payload.
- Adding a validation sequence before testing REST API modules in order to extract all path / query parameters for REST API endpoints.
## Verifying this change
This test is run successfully against all REST API in `DispatcherRestEndpoint`.
This test will automatically pickup new endpoints for testing as long as support is added to `DispatcherRestEndpoint`.
If new endpoint requires additional path / payload / query parameter, test will be skipped instead of failing for the new endpoints.
## Does this pull request potentially affect one of the following parts:
No
## Documentation
No documentations for this test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walterddr/flink FLINK-8986-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6054.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6054
----
commit ea127374af896d9dc82c1a9911f65b2360705397
Author: Rong Rong <ro...@...>
Date: 2018-04-17T20:45:23Z
initial commit to support CLI test, excluding YARN test
commit 119895ffdfb783985892fafdde5fc4e0646a260a
Author: Rong Rong <wa...@...>
Date: 2018-04-25T18:51:12Z
adding in rest api tests, it went through 34 and skipped 6 which requires more data. Following completion of this test should add payload to requestBodies.yaml for testing
commit 7dc064a23854afe95737afb8602bc25a2f3aca3d
Author: Rong Rong <ro...@...>
Date: 2018-04-27T00:27:50Z
adding in post test with payload
commit 977abed8b63ab91e7b8a51df62df28d1ea0ec284
Author: Rong Rong <wa...@...>
Date: 2018-04-27T05:05:11Z
adding in all testing request payloads and all 43 tests are passing
----
---