You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/26 13:45:08 UTC
[GitHub] [tvm] tqchen opened a new pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
tqchen opened a new pull request #7750:
URL: https://github.com/apache/tvm/pull/7750
The log(info) stops working for web runtime due to the usage of time
function.
- Introduce TVM_LOG_CUSTOMIZE anf TVM_LOG_STACK_TRACE.
- Reorganize the log customization code to wasm_runtime(so non-gpu usecase can apply).
- Update the testcase to cover the logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7750:
URL: https://github.com/apache/tvm/pull/7750#issuecomment-808231650
cc @tkonolige @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7750:
URL: https://github.com/apache/tvm/pull/7750#issuecomment-808231650
cc @junrushao1994 @tkonolige
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7750:
URL: https://github.com/apache/tvm/pull/7750#discussion_r602402636
##########
File path: include/tvm/runtime/logging.h
##########
@@ -55,6 +66,15 @@
#define TVM_USE_LIBBACKTRACE 0
#endif
+/*!
+ * \brief Whether or not customize the logging output.
+ * If log customize is enabled, the user must implement
+ * runtime::detail::LogFatalImpl and runtime::detail::LogMessageImpl
Review comment:
```suggestion
* tvm::runtime::detail::LogFatalImpl and tvm::runtime::detail::LogMessageImpl
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7750:
URL: https://github.com/apache/tvm/pull/7750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7750: [RUNTIME][WEB] Cleanup logging for web runtime.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7750:
URL: https://github.com/apache/tvm/pull/7750#issuecomment-808603577
Thanks @tqchen @tkonolige! I am going to merge it in :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org