You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/13 02:48:00 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

mjsax commented on a change in pull request #10529:
URL: https://github.com/apache/kafka/pull/10529#discussion_r612089734



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##########
@@ -153,7 +156,8 @@ public void shouldNotCreateTopicsWithEmptyInput() throws Exception {
 
     @Test
     public void shouldOnlyRetryNotSuccessfulFuturesDuringSetup() {
-        final AdminClient admin = EasyMock.createNiceMock(AdminClient.class);
+        final AdminClient admin = EasyMock.createStrictMock(AdminClient.class);
+        config.put(ConsumerConfig.MAX_POLL_INTERVAL_MS_CONFIG, 10_000L);

Review comment:
       In test setup, we reduce max.poll to 100ms, to increasing it to 10 sec for this test should be sufficient.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org