You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 04:50:19 UTC

[GitHub] [arrow] cyb70289 opened a new pull request, #14515: ARROW-18162: [C++] Add Arm SVE compiler options

cyb70289 opened a new pull request, #14515:
URL: https://github.com/apache/arrow/pull/14515

   As xsimd only supports fixed-size SVE, we have to specify SIMD level explicitly on command line. And the binary can only run on hardware with that vector size. Otherwise, the code behaviour is undefined. E.g., cmake -DARROW_SIMD_LEVEL=SVE256 -DARROW_ARMV8_ARCH=armv8-a+sve According macro "ARROW_HAVE_SVE256" and cmake variable are defined.
   
   We can also leverage compiler auto vectorization to generate size agnostic SVE code without specifying the vector size. E.g., cmake -DARROW_SIMD_LEVEL=SVE -DARROW_ARMV8_ARCH=armv8-a+sve
   
   This PR also removes some unused arm64 arch options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1005738211


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -496,14 +494,24 @@ if(ARROW_CPU_FLAG STREQUAL "armv8")
     endif()
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")
 
+    set(ARROW_HAVE_NEON ON)

Review Comment:
   Yes, NEON is always available for aarch64.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1005602315


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -496,14 +494,24 @@ if(ARROW_CPU_FLAG STREQUAL "armv8")
     endif()
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")
 
+    set(ARROW_HAVE_NEON ON)
     add_definitions(-DARROW_HAVE_NEON)
 
-    if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
-      add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
-    endif()
-    # armv8.1+ implies crc support
-    if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
-      add_definitions(-DARROW_HAVE_ARMV8_CRC)
+    if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
+      if(NOT ARROW_ARMV8_ARCH_FLAG MATCHES "\\+sve")
+        message(FATAL_ERROR "SIMD Level is set to ${ARROW_SIMD_LEVEL} but SVE is not enabled in compiler options. "
+                            "Add \"-DARROW_ARMV8_ARCH=armv8-a+sve\" to cmake command line to enable SVE."

Review Comment:
   Is it useful to error on this? Why not automatically enable SVE when it's given in ARROW_SIMD_LEVEL?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1297904838

   conda-osx-clang-py310/py37 build error looks not related.
   https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=38774&view=logs&j=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf&t=88ee2fb8-46fd-5c68-fde3-1c8d31ba2a5f&l=3570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1005763894


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -496,14 +494,24 @@ if(ARROW_CPU_FLAG STREQUAL "armv8")
     endif()
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")
 
+    set(ARROW_HAVE_NEON ON)
     add_definitions(-DARROW_HAVE_NEON)
 
-    if(ARROW_ARMV8_ARCH_FLAG MATCHES "\\+crypto")
-      add_definitions(-DARROW_HAVE_ARMV8_CRYPTO)
-    endif()
-    # armv8.1+ implies crc support
-    if(ARROW_ARMV8_ARCH_FLAG MATCHES "armv8\\.[1-9]|\\+crc")
-      add_definitions(-DARROW_HAVE_ARMV8_CRC)
+    if(ARROW_SIMD_LEVEL MATCHES "SVE[0-9]*")
+      if(NOT ARROW_ARMV8_ARCH_FLAG MATCHES "\\+sve")
+        message(FATAL_ERROR "SIMD Level is set to ${ARROW_SIMD_LEVEL} but SVE is not enabled in compiler options. "
+                            "Add \"-DARROW_ARMV8_ARCH=armv8-a+sve\" to cmake command line to enable SVE."

Review Comment:
   I'm thinking about removing this cmake option `ARROW_ARMV8_ARCH`, and use only `ARROW_SIMD_LEVEL`.
   https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L204
   
   `ARROW_ARMV8_ARCH` is append to `gcc -march=???`, it's only for Arm. x86 doesn't need `-march` as x86 has compiler options for each feature, e.g., `-msse4.2`, `-mavx2`, etc, to enable specific SIMD instructions.
   But Arm doesn't have these compiler options, CPU features are set by `-march` only, e.g., `-march=armv8-a+sve`, `-march=armv8.2-a+crypto`, etc.
   Specify `-march` by cmake command line gives more flexibility, but looks most of the time it also introduces unnecessary complexity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1298356407

   Benchmark runs are scheduled for baseline = 2a5c773611e1d30c1a1a9503f9640565110d96bc and contender = 16fd7f3fabbe663c161899d197deb66a7ec188b5. 16fd7f3fabbe663c161899d197deb66a7ec188b5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8614be4c8cab43ea9ed82c6de79545d8...f50d869376ec4e82a94fa6e41df410dc/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e83780b72720462fa7f8f64878731b69...5a87beb8aeff4cf2aa16c6f04e4dd91b/)
   [Finished :arrow_down:0.54% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/edee40175cbc479abc73932edb89e692...84ae095b78ae426882f111ed0ba42cc7/)
   [Finished :arrow_down:0.32% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/63e0351b3dc84b13a37370a8acb6235a...ea9fdb9673d04d4db61eee81eaa85af0/)
   Buildkite builds:
   [Finished] [`16fd7f3f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1798)
   [Failed] [`16fd7f3f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1819)
   [Finished] [`16fd7f3f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1786)
   [Finished] [`16fd7f3f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1811)
   [Finished] [`2a5c7736` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1797)
   [Failed] [`2a5c7736` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1818)
   [Finished] [`2a5c7736` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1785)
   [Finished] [`2a5c7736` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1810)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1296882494

   Revision: f99b57af36e8df90adad78c0dfe00b8632cd929e
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-19dd1864f2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-19dd1864f2)
   
   |Task|Status|
   |----|------|
   |conda-linux-gcc-py310-arm64|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py310-arm64)](https://github.com/ursacomputing/crossbow/tree/actions-19dd1864f2-azure-conda-linux-gcc-py310-arm64)|
   |conda-linux-gcc-py310-cpu|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py310-cpu)](https://github.com/ursacomputing/crossbow/runs/9199530362)|
   |conda-linux-gcc-py310-cuda|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py310-cuda)](https://github.com/ursacomputing/crossbow/runs/9199523171)|
   |conda-linux-gcc-py310-ppc64le|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py310-ppc64le)](https://github.com/ursacomputing/crossbow/runs/9199524508)|
   |conda-linux-gcc-py37-arm64|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py37-arm64)](https://github.com/ursacomputing/crossbow/runs/9199541188)|
   |conda-linux-gcc-py37-cpu-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py37-cpu-r40)](https://github.com/ursacomputing/crossbow/runs/9199532496)|
   |conda-linux-gcc-py37-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py37-cpu-r41)](https://github.com/ursacomputing/crossbow/runs/9199535229)|
   |conda-linux-gcc-py37-cuda|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py37-cuda)](https://github.com/ursacomputing/crossbow/runs/9199527818)|
   |conda-linux-gcc-py37-ppc64le|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py37-ppc64le)](https://github.com/ursacomputing/crossbow/runs/9199526599)|
   |conda-linux-gcc-py38-arm64|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py38-arm64)](https://github.com/ursacomputing/crossbow/runs/9199539947)|
   |conda-linux-gcc-py38-cpu|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py38-cpu)](https://github.com/ursacomputing/crossbow/runs/9199542337)|
   |conda-linux-gcc-py38-cuda|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py38-cuda)](https://github.com/ursacomputing/crossbow/runs/9199525461)|
   |conda-linux-gcc-py38-ppc64le|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py38-ppc64le)](https://github.com/ursacomputing/crossbow/runs/9199531515)|
   |conda-linux-gcc-py39-arm64|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py39-arm64)](https://github.com/ursacomputing/crossbow/runs/9199528884)|
   |conda-linux-gcc-py39-cpu|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py39-cpu)](https://github.com/ursacomputing/crossbow/runs/9199538600)|
   |conda-linux-gcc-py39-cuda|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py39-cuda)](https://github.com/ursacomputing/crossbow/runs/9199521717)|
   |conda-linux-gcc-py39-ppc64le|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-19dd1864f2-azure-conda-linux-gcc-py39-ppc64le)](https://github.com/ursacomputing/crossbow/runs/9199533870)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1297094889

   @github-actions crossbow submit conda-osx-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1297104813

   Revision: f99b57af36e8df90adad78c0dfe00b8632cd929e
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-457a7b106d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-457a7b106d)
   
   |Task|Status|
   |----|------|
   |conda-osx-arm64-clang-py310|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-arm64-clang-py310)](https://github.com/ursacomputing/crossbow/runs/9203144681)|
   |conda-osx-arm64-clang-py37|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-arm64-clang-py37)](https://github.com/ursacomputing/crossbow/runs/9203143574)|
   |conda-osx-arm64-clang-py38|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-arm64-clang-py38)](https://github.com/ursacomputing/crossbow/runs/9203136889)|
   |conda-osx-arm64-clang-py39|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-arm64-clang-py39)](https://github.com/ursacomputing/crossbow/runs/9203141903)|
   |conda-osx-clang-py310|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py310)](https://github.com/ursacomputing/crossbow/runs/9203149717)|
   |conda-osx-clang-py37|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py37)](https://github.com/ursacomputing/crossbow/runs/9203145971)|
   |conda-osx-clang-py37-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py37-r40)](https://github.com/ursacomputing/crossbow/runs/9203140410)|
   |conda-osx-clang-py37-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py37-r41)](https://github.com/ursacomputing/crossbow/runs/9203135975)|
   |conda-osx-clang-py38|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py38)](https://github.com/ursacomputing/crossbow/runs/9203139279)|
   |conda-osx-clang-py39|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-457a7b106d-azure-conda-osx-clang-py39)](https://github.com/ursacomputing/crossbow/runs/9203137851)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1006503860


##########
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh:
##########
@@ -39,11 +39,6 @@ else
     export PYARROW_WITH_CUDA=0
 fi
 
-# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 merged pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 merged PR #14515:
URL: https://github.com/apache/arrow/pull/14515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1006502948


##########
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh:
##########
@@ -39,11 +39,6 @@ else
     export PYARROW_WITH_CUDA=0
 fi
 
-# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.

Review Comment:
   `conda-linux-*` and `conda-osx-*` but we should wait for #14102.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1291521939

   https://issues.apache.org/jira/browse/ARROW-18162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1005603437


##########
python/CMakeLists.txt:
##########
@@ -129,7 +129,7 @@ endif()
 if(NOT DEFINED ARROW_ARMV8_ARCH)
   set(ARROW_ARMV8_ARCH
       "armv8-a"
-      CACHE STRING "Arm64 arch and extensions: armv8-a, armv8-a or armv8-a+crc+crypto")
+      CACHE STRING "Arm64 arch and extensions")

Review Comment:
   Why do we have this option separately in Python, by the way?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1005601107


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -496,14 +494,24 @@ if(ARROW_CPU_FLAG STREQUAL "armv8")
     endif()
     set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} ${ARROW_ARMV8_ARCH_FLAG}")
 
+    set(ARROW_HAVE_NEON ON)

Review Comment:
   Is NEON always available with SVE?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1292160696

   > It seems we could also use SVE in `src/arrow/util/bpacking.cc`, `src/arrow/util/utf8_internal.h`, as well as `src/arrow/csv/lexing_internal.h` and `src/arrow/csv/writer.cc`?
   
   Yes. SVE may be better when longer vector size is beneficial, or to leverage operations (e.g, scatter/gather) not availble in NEON.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on a diff in pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #14515:
URL: https://github.com/apache/arrow/pull/14515#discussion_r1006493489


##########
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh:
##########
@@ -39,11 +39,6 @@ else
     export PYARROW_WITH_CUDA=0
 fi
 
-# Resolve: Make Error at cmake_modules/SetupCxxFlags.cmake:338 (message): Unsupported arch flag: -march=.

Review Comment:
   @kou which tests shall we run against this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1296872602

   @github-actions crossbow submit conda-linux-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] cyb70289 commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1296810207

   @github-actions crossbow submit conda-{linux,osx}-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1296849018

   ```
   Unable to match any tasks for `conda-{linux,osx}-*`
   The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/3360036059
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1291521954

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #14515: ARROW-18162: [C++] Add Arm SVE compiler options

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14515:
URL: https://github.com/apache/arrow/pull/14515#issuecomment-1291951556

   It seems we could also use SVE in `src/arrow/util/bpacking.cc`, `src/arrow/util/utf8_internal.h`, as well as `src/arrow/csv/lexing_internal.h` and `src/arrow/csv/writer.cc`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org