You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/11 19:04:32 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1229: Joystick support for the Olimex P407

Ouss4 opened a new pull request #1229:
URL: https://github.com/apache/incubator-nuttx/pull/1229


   ## Summary
   Add support for the Olimex P407 inboard joystick.
   
   ## Impact
   No impact in any other config.
   
   ## Testing
   The djoystick apps' example.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1229: Joystick support for the Olimex P407 board

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1229:
URL: https://github.com/apache/incubator-nuttx/pull/1229


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1229: Joystick support for the Olimex P407 board

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1229:
URL: https://github.com/apache/incubator-nuttx/pull/1229#issuecomment-642878621


   I don't know what to do with that little style error, it's just one character over the limit, however, breaking the line would mean bringing the whole "struct djoy_pollevents_s", which I find ugly and unreadable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1229: Joystick support for the Olimex P407 board

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1229:
URL: https://github.com/apache/incubator-nuttx/pull/1229#issuecomment-642893220


   > 
   > 
   > I don't know what to do with that little style error, it's just one character over the limit, however, breaking the line would mean bringing the whole "struct djoy_pollevents_s", which I find ugly and unreadable.
   
   I don't see this as particularly ugly:
   
        * Argument:    A read-only pointer to an instance of struct
                       djoy_pollevents_s
   
   I do that all of the time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1229: Joystick support for the Olimex P407 board

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1229:
URL: https://github.com/apache/incubator-nuttx/pull/1229#issuecomment-642898435


   I was thinking about putting the whole "struct djoy_pollevents_s" in a new line which would've made the line look a little hollow.
   I kept the "struct" as you suggested, that's better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org