[GitHub] [calcite] asereda-gs commented on a change in pull request #1184: [CALCITE-3027] Support like query in Elasticsearch

[GitBox <gi...@apache.org>]

asereda-gs commented on a change in pull request #1184: [CALCITE-3027] Support like query in Elasticsearch
URL: https://github.com/apache/calcite/pull/1184#discussion_r283064708
 
 

 ##########
 File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java
 ##########
 @@ -736,15 +736,15 @@ private SimpleQueryExpression(NamedFieldExpression rel) {
     }
 
     @Override public QueryExpression like(LiteralExpression literal) {
-      builder = regexpQuery(getFieldReference(), literal.stringValue());
+      builder = wildcardQuery(getFieldReference(), literal.stringValue());
 
 Review comment:
   Pls see my other comment about `wildcard` vs `regexp` for sql `like` equivalent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services