You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Jayson Minard (JIRA)" <ji...@apache.org> on 2009/05/13 20:15:46 UTC
[jira] Created: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
---------------------------------------------------------------------------------------------------------------------------------
Key: SOLR-1164
URL: https://issues.apache.org/jira/browse/SOLR-1164
Project: Solr
Issue Type: Improvement
Components: update
Affects Versions: 1.3
Reporter: Jayson Minard
When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Jayson Minard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711318#action_12711318 ]
Jayson Minard commented on SOLR-1164:
-------------------------------------
So I need to take this patch, then fix SOLR-1162 over the top of it, correct? I'll see what changed across the two and make sure SOLR-1162 depends on this patch and is only the changes beyond it.
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-1164:
----------------------------------------
Fix Version/s: 1.5
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Jayson Minard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712128#action_12712128 ]
Jayson Minard commented on SOLR-1164:
-------------------------------------
The UpdateRequest has get methods for getting the individual lists back that can be deprecated but harder to implement their replacement with everything lumped together. So could go either way on that one. Will look at options there when I get back to updating that patch soon.
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709394#action_12709394 ]
Noble Paul commented on SOLR-1164:
----------------------------------
I am gonna rewrite JavaBinUpdateRequestCodec to stream everything doc, deletebyid,deletebyquery
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul reassigned SOLR-1164:
--------------------------------
Assignee: Noble Paul
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1164:
-----------------------------
Attachment: SOLR-1164.patch
A new class added to help stream a javabin encoded data
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712350#action_12712350 ]
Noble Paul commented on SOLR-1164:
----------------------------------
it should not be a problem. the NamedList#getAll(String name) should let you implement that
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1164:
-----------------------------
Attachment: SOLR-1164.patch
cleanup patch
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711460#action_12711460 ]
Noble Paul commented on SOLR-1164:
----------------------------------
yes. apply SOLR-1162 over this patch.if any changes are required for this issue we can do it
Another suggestion for 1162
you may not need so many new classes for each type of request.
Just keep one NamedList in the UpdateRequest object and keep adding items to that with proper names. say docs,deleteByid,DeleteByQ etc. that can make it very simple
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
> Assignee: Noble Paul
> Attachments: SOLR-1164.patch, SOLR-1164.patch
>
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1164) BinaryUpdateRequestHandler and
JavaBinUpdateRequestCodec do not maintain order of the commands as
serialized in the binary format
Posted by "Jayson Minard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709050#action_12709050 ]
Jayson Minard commented on SOLR-1164:
-------------------------------------
Noticed that SolrJ classes are used in the server to implement the handler side which makes it hard to split the patch. If we want to clean that up, the patch can be split but otherwise leaving it in SOLR-1162 and tracking both sides of the coin by leaving this issue here.
> BinaryUpdateRequestHandler and JavaBinUpdateRequestCodec do not maintain order of the commands as serialized in the binary format
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1164
> URL: https://issues.apache.org/jira/browse/SOLR-1164
> Project: Solr
> Issue Type: Improvement
> Components: update
> Affects Versions: 1.3
> Reporter: Jayson Minard
>
> When sending commands in the Java binary format to the BinaryUpdateRequestHandler it does not process them in the order received. It processes all add/updates then delete by id then delete by query regardless of what is sent. See SOLR-1162 for related issue and patch that covers both issues (they are intertwined since some classes are shared on both sides of the wire)
> I wanted a separate issue covering this so that it is seen from the server viewpoint and not just as a client API issue as other clients writing the binary form would be unable to maintain order of commands as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.