You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/19 00:57:06 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #81: Only pass SSE headers for multipart upload requests
mdedetrich opened a new pull request, #81:
URL: https://github.com/apache/incubator-pekko-connectors/pull/81
This PR fixes https://github.com/akka/alpakka/issues/2906, Alpakka created a regression whereby their latest Alpakka BSL release (4.0.0) has multipart upload broken.
According to S3 docs (see https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#API_CompleteMultipartUpload_Examples), you are not allowed to have any other headers that is not SSE related.
I tested this on my companies S3 account and I can confirm that it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #81: Only pass SSE headers for multipart upload requests
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #81:
URL: https://github.com/apache/incubator-pekko-connectors/pull/81#discussion_r1171222627
##########
s3/src/test/scala/docs/scaladsl/S3SinkSpec.scala:
##########
@@ -286,10 +288,13 @@ class S3SinkSpec extends S3WireMockBase with S3ClientIntegrationSpec with Option
.withHeader(sseCSourceKeyHeader, new EqualToPattern(sseCSourceKeyHeaderValue))
.withHeader(requestPayerHeader, new EqualToPattern(requestPayerHeaderValue)))
- // No SSE-C headers required for CompleteMultipartUpload
+ // SSE headers only
mock.verifyThat(
postRequestedFor(urlEqualTo(s"/$targetBucketKey?uploadId=$uploadId"))
- .withHeader(requestPayerHeader, new EqualToPattern(requestPayerHeaderValue)))
+ .withHeader(sseCAlgorithmHeader, new EqualToPattern(sseCAlgorithmHeaderValue))
+ .withHeader(sseCKeyHeader, new EqualToPattern(sseCKeyHeaderValue))
+ .withHeader(sseCKeyHeaderMd5, new EqualToPattern(sseCKeyHeaderMd5Value))
+ .withoutHeader(requestPayerHeader))
Review Comment:
I just followed the same style that is done in the rest of the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #81: Only pass SSE headers for multipart upload requests
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #81:
URL: https://github.com/apache/incubator-pekko-connectors/pull/81#discussion_r1171221746
##########
s3/src/test/scala/docs/scaladsl/S3SinkSpec.scala:
##########
@@ -286,10 +288,13 @@ class S3SinkSpec extends S3WireMockBase with S3ClientIntegrationSpec with Option
.withHeader(sseCSourceKeyHeader, new EqualToPattern(sseCSourceKeyHeaderValue))
.withHeader(requestPayerHeader, new EqualToPattern(requestPayerHeaderValue)))
- // No SSE-C headers required for CompleteMultipartUpload
+ // SSE headers only
mock.verifyThat(
postRequestedFor(urlEqualTo(s"/$targetBucketKey?uploadId=$uploadId"))
- .withHeader(requestPayerHeader, new EqualToPattern(requestPayerHeaderValue)))
+ .withHeader(sseCAlgorithmHeader, new EqualToPattern(sseCAlgorithmHeaderValue))
+ .withHeader(sseCKeyHeader, new EqualToPattern(sseCKeyHeaderValue))
+ .withHeader(sseCKeyHeaderMd5, new EqualToPattern(sseCKeyHeaderMd5Value))
+ .withoutHeader(requestPayerHeader))
Review Comment:
`new EqualToPattern(...)` would looks better with `EqualToPattern(...) `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #81: Only pass SSE headers for multipart upload requests
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #81:
URL: https://github.com/apache/incubator-pekko-connectors/pull/81#issuecomment-1514390192
I have added this PR onto the 1.0.0 project because currently the Pekko S3 client is broken without this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin merged pull request #81: Only pass SSE headers for multipart upload requests
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #81:
URL: https://github.com/apache/incubator-pekko-connectors/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org