You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/04/04 08:05:41 UTC
[Impala-ASF-CR] IMPALA-11038: Zipping unnest from view
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18094 )
Change subject: IMPALA-11038: Zipping unnest from view
......................................................................
Patch Set 8: Code-Review+2
(3 comments)
I still think that there are possibilities to simplify this patch, but it is probably better to work on these in another change once https://gerrit.cloudera.org/#/c/17847/ is also merged.
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@510
PS7, Line 510: If the table ref is originated from a view then also add the tuple IDs for the
: // respective table refs from the view.
> I think this is still true as e.g. for a from clause unnest I still had to
Oops, I have missed some of the callsites.
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java
File fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java:
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java@206
PS7, Line 206: isCollectionInSelectList
> I use it twice in UnnestExpr.
oops, why did I miss that :/
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/FromClause.java
File fe/src/main/java/org/apache/impala/analysis/FromClause.java:
http://gerrit.cloudera.org:8080/#/c/18094/7/fe/src/main/java/org/apache/impala/analysis/FromClause.java@150
PS7, Line 150: // Don't do any checks of the collection that came from a view as getTable() would
: // return null in that case.
: if (collRef.getTable() == null) return;
> removing this check would crash this query:
In the example query the arrays do not come from a view, while the comment says that it is related to collectionTableRefs from views.
--
To view, visit http://gerrit.cloudera.org:8080/18094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f649dda9e41f257e7f6596193d07b24049f92a
Gerrit-Change-Number: 18094
Gerrit-PatchSet: 8
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Apr 2022 08:05:41 +0000
Gerrit-HasComments: Yes