[GitHub] [pulsar] codelipenghui commented on a change in pull request #10686: Upgrade BookKeeper to 4.14.1

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #10686:
URL: https://github.com/apache/pulsar/pull/10686#discussion_r642745099



##########
File path: pulsar-sql/presto-distribution/LICENSE
##########
@@ -413,18 +413,18 @@ The Apache Software License, Version 2.0
     - async-http-client-2.12.1.jar
     - async-http-client-netty-utils-2.12.1.jar
   * Apache Bookkeeper
-    - bookkeeper-common-4.13.0.jar
-    - bookkeeper-common-allocator-4.13.0.jar
-    - bookkeeper-proto-4.13.0.jar
-    - bookkeeper-server-4.13.0.jar
-    - bookkeeper-stats-api-4.13.0.jar
-    - bookkeeper-tools-framework-4.13.0.jar
-    - circe-checksum-4.13.0.jar
-    - codahale-metrics-provider-4.13.0.jar
-    - cpu-affinity-4.13.0.jar
-    - http-server-4.13.0.jar
-    - prometheus-metrics-provider-4.13.0.jar
-    - codahale-metrics-provider-4.13.0.jar
+    - bookkeeper-common-4.14.0.jar
+    - bookkeeper-common-allocator-4.14.0.jar
+    - bookkeeper-proto-4.14.0.jar
+    - bookkeeper-server-4.14.0.jar
+    - bookkeeper-stats-api-4.14.0.jar
+    - bookkeeper-tools-framework-4.14.0.jar
+    - circe-checksum-4.14.0.jar
+    - codahale-metrics-provider-4.14.0.jar
+    - cpu-affinity-4.14.0.jar
+    - http-server-4.14.0.jar
+    - prometheus-metrics-provider-4.14.0.jar
+    - codahale-metrics-provider-4.14.0.jar

Review comment:
       Should also fixes the version in the LICENSE

##########
File path: distribution/server/src/assemble/LICENSE.bin.txt
##########
@@ -390,31 +390,31 @@ The Apache Software License, Version 2.0
     - org.apache.logging.log4j-log4j-1.2-api-2.14.0.jar
  * Java Native Access JNA -- net.java.dev.jna-jna-4.2.0.jar
  * BookKeeper
-    - org.apache.bookkeeper-bookkeeper-common-4.13.0.jar
-    - org.apache.bookkeeper-bookkeeper-common-allocator-4.13.0.jar
-    - org.apache.bookkeeper-bookkeeper-proto-4.13.0.jar
-    - org.apache.bookkeeper-bookkeeper-server-4.13.0.jar
-    - org.apache.bookkeeper-bookkeeper-tools-framework-4.13.0.jar
-    - org.apache.bookkeeper-circe-checksum-4.13.0.jar
-    - org.apache.bookkeeper-cpu-affinity-4.13.0.jar
-    - org.apache.bookkeeper-statelib-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-api-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-common-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-java-client-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-java-client-base-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-proto-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-server-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-service-api-4.13.0.jar
-    - org.apache.bookkeeper-stream-storage-service-impl-4.13.0.jar
-    - org.apache.bookkeeper.http-http-server-4.13.0.jar
-    - org.apache.bookkeeper.http-vertx-http-server-4.13.0.jar
-    - org.apache.bookkeeper.stats-bookkeeper-stats-api-4.13.0.jar
-    - org.apache.bookkeeper.stats-prometheus-metrics-provider-4.13.0.jar
-    - org.apache.distributedlog-distributedlog-common-4.13.0.jar
-    - org.apache.distributedlog-distributedlog-core-4.13.0-tests.jar
-    - org.apache.distributedlog-distributedlog-core-4.13.0.jar
-    - org.apache.distributedlog-distributedlog-protocol-4.13.0.jar
-    - org.apache.bookkeeper.stats-codahale-metrics-provider-4.13.0.jar
+    - org.apache.bookkeeper-bookkeeper-common-4.14.0.jar
+    - org.apache.bookkeeper-bookkeeper-common-allocator-4.14.0.jar
+    - org.apache.bookkeeper-bookkeeper-proto-4.14.0.jar
+    - org.apache.bookkeeper-bookkeeper-server-4.14.0.jar
+    - org.apache.bookkeeper-bookkeeper-tools-framework-4.14.0.jar
+    - org.apache.bookkeeper-circe-checksum-4.14.0.jar
+    - org.apache.bookkeeper-cpu-affinity-4.14.0.jar
+    - org.apache.bookkeeper-statelib-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-api-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-common-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-java-client-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-java-client-base-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-proto-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-server-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-service-api-4.14.0.jar
+    - org.apache.bookkeeper-stream-storage-service-impl-4.14.0.jar
+    - org.apache.bookkeeper.http-http-server-4.14.0.jar
+    - org.apache.bookkeeper.http-vertx-http-server-4.14.0.jar
+    - org.apache.bookkeeper.stats-bookkeeper-stats-api-4.14.0.jar
+    - org.apache.bookkeeper.stats-prometheus-metrics-provider-4.14.0.jar
+    - org.apache.distributedlog-distributedlog-common-4.14.0.jar
+    - org.apache.distributedlog-distributedlog-core-4.14.0-tests.jar
+    - org.apache.distributedlog-distributedlog-core-4.14.0.jar
+    - org.apache.distributedlog-distributedlog-protocol-4.14.0.jar
+    - org.apache.bookkeeper.stats-codahale-metrics-provider-4.14.0.jar

Review comment:
       Should also fixes the version in the LICENSE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org