You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/29 09:02:45 UTC

[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #579: netutils/dhcpc: configurable Bootstrap flags

anchao opened a new pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579


   ## Summary
   
   netutils/dhcpc: configurable Bootstrap flags
   
   Change-Id: I9a364fda2ac536422ef3294a7217474f48eaad21
   Signed-off-by: chao.an <an...@xiaomi.com>
   
   ## Impact
   
   depends on: https://github.com/apache/incubator-nuttx/pull/2774
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#discussion_r567076894



##########
File path: netutils/dhcpc/Kconfig
##########
@@ -29,4 +29,12 @@ config NETUTILS_DHCPC_RETRIES
 		This setting determines how many times resolver retries request
 		until failing.
 
+config NETUTILS_DHCPC_BOOTP_FLAGS
+	hex "Flags of Bootstrap"
+	default 0x0
+	---help---
+		This setting to set the BOOTP boardcast flags.

Review comment:
       it is boardcast or broadcast?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#discussion_r567341750



##########
File path: netutils/dhcpc/Kconfig
##########
@@ -29,4 +29,12 @@ config NETUTILS_DHCPC_RETRIES
 		This setting determines how many times resolver retries request
 		until failing.
 
+config NETUTILS_DHCPC_BOOTP_FLAGS
+	hex "Flags of Bootstrap"
+	default 0x0

Review comment:
       Should the default be 0x8000 to retain broadcast as the default instead of unicast?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#issuecomment-777952755


   @anchao apologies. I forgot about this one, been a busy few weeks. LGTM. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#discussion_r567168978



##########
File path: netutils/dhcpc/Kconfig
##########
@@ -29,4 +29,12 @@ config NETUTILS_DHCPC_RETRIES
 		This setting determines how many times resolver retries request
 		until failing.
 
+config NETUTILS_DHCPC_BOOTP_FLAGS
+	hex "Flags of Bootstrap"
+	default 0x0
+	---help---
+		This setting to set the BOOTP boardcast flags.

Review comment:
       ooooh, should be "broadcast"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#discussion_r568011433



##########
File path: netutils/dhcpc/Kconfig
##########
@@ -29,4 +29,12 @@ config NETUTILS_DHCPC_RETRIES
 		This setting determines how many times resolver retries request
 		until failing.
 
+config NETUTILS_DHCPC_BOOTP_FLAGS
+	hex "Flags of Bootstrap"
+	default 0x0

Review comment:
       Got




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] anchao commented on pull request #579: netutils/dhcpc: configurable Bootstrap flags

Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #579:
URL: https://github.com/apache/incubator-nuttx-apps/pull/579#issuecomment-777948927


   Hi, @btashton ,
   
   Could you please review this change again?  I have resolved valuable comments your mentioned before, thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org